Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix `notDeepEqual` API #4971

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@JungMinu
Copy link
Member

commented Jan 30, 2016

API calls in assert are deepEqual(), not notDeepEqual().
use notDeepEqual to make it clear.

@JungMinu JungMinu added the doc label Jan 30, 2016

@JungMinu JungMinu self-assigned this Jan 30, 2016

@mscdex mscdex added the assert label Jan 30, 2016

@Trott

This comment has been minimized.

Copy link
Member

commented Jan 30, 2016

LGTM

@stevemao

This comment has been minimized.

Copy link
Member

commented Jan 30, 2016

LGTM

doc: fix `notDeepEqual` API
API calls in `assert` are `deepEqual()`, not `notDeepEqual()`.
use `notDeepEqual` to make it clear.

PR-URL: #4971
Reviewed-By: Rich Trott <rtrott@gmail.com>

JungMinu added a commit that referenced this pull request Jan 31, 2016

doc: fix `notDeepEqual` API
API calls in `assert` are `deepEqual()`, not `notDeepEqual()`.
use `notDeepEqual` to make it clear.

PR-URL: #4971
Reviewed-By: Rich Trott <rtrott@gmail.com>
@JungMinu

This comment has been minimized.

Copy link
Member Author

commented Jan 31, 2016

Thanks, landed in de3e94b

@targos targos closed this Jan 31, 2016

@JungMinu JungMinu deleted the JungMinu:JungMinu-doc-api branch Jan 31, 2016

rvagg added a commit that referenced this pull request Feb 8, 2016

doc: fix `notDeepEqual` API
API calls in `assert` are `deepEqual()`, not `notDeepEqual()`.
use `notDeepEqual` to make it clear.

PR-URL: #4971
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins

This comment has been minimized.

Copy link
Member

commented Feb 17, 2016

Blocked from backporting due to other Doc fixes

MylesBorins added a commit that referenced this pull request Feb 22, 2016

doc: fix `notDeepEqual` API
API calls in `assert` are `deepEqual()`, not `notDeepEqual()`.
use `notDeepEqual` to make it clear.

PR-URL: #4971
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins added a commit that referenced this pull request Feb 22, 2016

doc: fix `notDeepEqual` API
API calls in `assert` are `deepEqual()`, not `notDeepEqual()`.
use `notDeepEqual` to make it clear.

PR-URL: #4971
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins added a commit that referenced this pull request Mar 2, 2016

doc: fix `notDeepEqual` API
API calls in `assert` are `deepEqual()`, not `notDeepEqual()`.
use `notDeepEqual` to make it clear.

PR-URL: #4971
Reviewed-By: Rich Trott <rtrott@gmail.com>

scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016

doc: fix `notDeepEqual` API
API calls in `assert` are `deepEqual()`, not `notDeepEqual()`.
use `notDeepEqual` to make it clear.

PR-URL: nodejs#4971
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.