Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: deprecate process.EventEmitter #5049

Merged
merged 1 commit into from Feb 4, 2016

Conversation

Projects
None yet
9 participants
@evanlucas
Copy link
Member

commented Feb 3, 2016

The comment stating it was deprecated was added in 2011 via
4ef8f06. It is time to actually deprecate it.

@evanlucas evanlucas force-pushed the evanlucas:depee branch Feb 3, 2016

@mscdex mscdex added the process label Feb 3, 2016

@mscdex

This comment has been minimized.

Copy link
Contributor

commented Feb 3, 2016

/cc @ChALkeR

Does anyone use this anywhere?

@evanlucas

This comment has been minimized.

Copy link
Member Author

commented Feb 3, 2016

@jasnell

This comment has been minimized.

Copy link
Member

commented Feb 3, 2016

LGTM

1 similar comment
@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Feb 3, 2016

LGTM

@evanlucas

This comment has been minimized.

Copy link
Member Author

commented Feb 3, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/1524/

Was the decision that we could deprecate in a minor version, or did we go with major?

@ChALkeR

This comment has been minimized.

Copy link
Member

commented Feb 3, 2016

@mscdex This is used, though the usage is not high. Will post a list a bit later today.

@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Feb 3, 2016

LGTM

1 similar comment
@thefourtheye

This comment has been minimized.

Copy link
Contributor

commented Feb 3, 2016

LGTM

@silverwind

This comment has been minimized.

Copy link
Contributor

commented Feb 3, 2016

@evanlucas you can get better results by quoting.

@evanlucas

This comment has been minimized.

Copy link
Member Author

commented Feb 3, 2016

oh nice

@ChALkeR

This comment has been minimized.

Copy link
Member

commented Feb 4, 2016

https://gist.github.com/ChALkeR/232fdf64be9c34c9c733, sorted by downloads count per month.
The first entry (array-difference) looks like a false positive to me.

I'm +1 for deprecating this, but in a semver-major, of course.

@ChALkeR ChALkeR added the semver-major label Feb 4, 2016

@evanlucas

This comment has been minimized.

Copy link
Member Author

commented Feb 4, 2016

Major works for me

@Fishrock123 Fishrock123 added this to the 6.0.0 milestone Feb 4, 2016

@silverwind

This comment has been minimized.

Copy link
Contributor

commented Feb 4, 2016

LGTM, looks to be low-impact.

@evanlucas

This comment has been minimized.

Copy link
Member Author

commented Feb 4, 2016

CI https://ci.nodejs.org/job/node-test-pull-request/1550/ one more time before landing since the last one was red.

node: deprecate process.EventEmitter
The comment stating it was deprecated was added in 2011 via
4ef8f06. It is time to
actually deprecate it.

PR-URL: #5049
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

@evanlucas evanlucas force-pushed the evanlucas:depee branch to 25751be Feb 4, 2016

@evanlucas evanlucas closed this Feb 4, 2016

@evanlucas evanlucas deleted the evanlucas:depee branch Feb 4, 2016

@evanlucas evanlucas merged commit 25751be into nodejs:master Feb 4, 2016

@evanlucas

This comment has been minimized.

Copy link
Member Author

commented Feb 4, 2016

Landed in 25751be. Thanks

@Cangit Cangit referenced this pull request Feb 11, 2016

Closed

Upgrading Node.js #5124

@jasnell jasnell referenced this pull request Mar 17, 2016

Closed

Planning for v6 #5766

scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016

node: deprecate process.EventEmitter
The comment stating it was deprecated was added in 2011 via
4ef8f06. It is time to
actually deprecate it.

PR-URL: nodejs#5049
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

@cjihrig cjihrig referenced this pull request May 18, 2016

Closed

process: remove deprecated process.EventEmitter #6862

2 of 2 tasks complete

cjihrig added a commit that referenced this pull request May 24, 2016

process: remove deprecated process.EventEmitter
process.EventEmitter was deprecated for v6. This commit removes
it for v7.

Refs: #5049
PR-URL: #6862
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.