Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add CTC meeting minutes 2016-01-27 #5057

Closed
wants to merge 1 commit into from

Conversation

@mscdex mscdex added the doc Issues and PRs related to the documentations. label Feb 3, 2016
* Ali Sheikh (observer) x
* Evan Lucas (observer)
* Rich Trott (observer)
* Michael Dawson (observer)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do those xes signify something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't in this meeting but I'm taking it to mean not-present and we continued this convention in the last meeting as well. Seems like that's not clear so do you have a better suggestion that's simple for note-takers? Deleting names has proven to be annoying for various reasons, although I guess I could remove them when I PR the minutes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe replace the x-es with (absent)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm under the heading "Present" , we are mentioning "absent"?

@silverwind
Copy link
Contributor

LGTM besides question.


Mikeal: hasn’t changed recently

Ben, James: read though it recently, lgtm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it's the actual chat transcript. If so we don't have to fix these typos

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More likely it was them expressing roughly the same thing and it was summarised in a single line for the sake of speed, it's pretty hard capturing discussion in real-time, we're not very skilled at taking it slowly!

So this is probably a typo, you're welcome to use your amazing fourth eye to point out typos and I'll happily fix them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-) :-) Sure, I can point them out whenever I find :-) But then we can leave the chat transcripts as they are right? It would give the readers a feel that they are really dealing with humans, who can make mistakes just like them :D

@bnoordhuis
Copy link
Member

LGTM

2 similar comments
@thefourtheye
Copy link
Contributor

LGTM

@jasnell
Copy link
Member

jasnell commented Feb 4, 2016

LGTM

jasnell pushed a commit that referenced this pull request Feb 4, 2016
PR-URL: #5057
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Feb 4, 2016

Landed in ce11a37

@jasnell jasnell closed this Feb 4, 2016
rvagg added a commit that referenced this pull request Feb 8, 2016
PR-URL: #5057
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
PR-URL: nodejs#5057
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants