Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix child-process-fork-regr-gh-2847 again #5179

Closed
wants to merge 1 commit into from

Conversation

@santigimeno
Copy link
Member

commented Feb 10, 2016

Windows is still sometimes failing with ECONNRESET. Bring back the
handling of this error as was initially introduced in PR #4442.

Windows is still sometimes failing with ECONNRESET. Bring back the
handling of this error as was initially introduced in PR #4442.
@santigimeno santigimeno force-pushed the santigimeno:fix_test_again branch to 3cf2461 Feb 10, 2016
@Trott

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Feb 10, 2016

CI looks good (two unrelated test failures that I'll look into).

@Trott

This comment has been minimized.

Copy link
Member

commented Feb 10, 2016

LGTM

@Trott

This comment has been minimized.

Copy link
Member

commented Feb 10, 2016

CI is broken until this lands and it's a small restore to test-only code that affects Windows only and that was there until very recently, so I'm going to make the judgment call that this can land sooner than usual. Posting this here to give anyone paying close attention a chance to say "no! disagree! stop!" in the next several minutes...

Trott added a commit to Trott/io.js that referenced this pull request Feb 10, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the
handling of this error as was initially introduced in PR nodejs#4442.

PR-URL: nodejs#5179
Reviewed-By: Rich Trott <rtrott@gmail.com>
Fixes: nodejs#3635
@Trott

This comment has been minimized.

Copy link
Member

commented Feb 10, 2016

Landed in 24667ee

@Trott Trott closed this Feb 10, 2016
rvagg added a commit that referenced this pull request Feb 15, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the
handling of this error as was initially introduced in PR #4442.

PR-URL: #5179
Reviewed-By: Rich Trott <rtrott@gmail.com>
Fixes: #3635
MylesBorins added a commit that referenced this pull request Feb 18, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the
handling of this error as was initially introduced in PR #4442.

PR-URL: #5179
Reviewed-By: Rich Trott <rtrott@gmail.com>
Fixes: #3635
MylesBorins added a commit that referenced this pull request Feb 18, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the
handling of this error as was initially introduced in PR #4442.

PR-URL: #5179
Reviewed-By: Rich Trott <rtrott@gmail.com>
Fixes: #3635
@MylesBorins MylesBorins referenced this pull request Feb 18, 2016
stefanmb added a commit to stefanmb/node that referenced this pull request Feb 23, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the
handling of this error as was initially introduced in PR nodejs#4442.

PR-URL: nodejs#5179
Reviewed-By: Rich Trott <rtrott@gmail.com>
Fixes: nodejs#3635
MylesBorins added a commit that referenced this pull request Mar 2, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the
handling of this error as was initially introduced in PR #4442.

PR-URL: #5179
Reviewed-By: Rich Trott <rtrott@gmail.com>
Fixes: #3635
@refack refack referenced this pull request Apr 27, 2017
3 of 3 tasks complete
refack added a commit to refack/node that referenced this pull request May 19, 2017
According to the explanation in nodejs#3635#issuecomment-157714683
And as a continuation to nodejs#5422 we also ignore EMFILE
"No more file descriptors are available,so no more files can be opened"

PR-URL: nodejs#12698
Fixes: nodejs#10286
Refs: nodejs#3635 (comment)
Refs: nodejs#5178
Refs: nodejs#5179
Refs: nodejs#4005
Refs: nodejs#5121
Refs: nodejs#5422
Refs: nodejs#12621 (comment)
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Jul 17, 2017
According to the explanation in #3635#issuecomment-157714683
And as a continuation to #5422 we also ignore EMFILE
"No more file descriptors are available,so no more files can be opened"

PR-URL: #12698
Fixes: #10286
Refs: #3635 (comment)
Refs: #5178
Refs: #5179
Refs: #4005
Refs: #5121
Refs: #5422
Refs: #12621 (comment)
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.