Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mitigate flaky test-debug-no-context #5269

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@Trott
Copy link
Member

commented Feb 17, 2016

Change test so that it passes on the occasional win10 access violation.

The workaround here can be undone when issue 5268 is resolved.

The test still detects the defect it was written to detect. There are
two assertions that detect the defect and only one was disabled.

Ref: #5268
Fixes: #4343

/cc @bnoordhuis

test: mitigate flaky test-debug-no-context
Change test so that it passes on the occasional win10 access violation.

The workaround here can be undone when issue 5268 is resolved.

The test still detects the defect it was written to detect. There are
two assertions that detect the defect and only one was disabled.

Ref: #5268
Fixes: #4343
@Trott

This comment has been minimized.

Copy link
Member Author

commented Feb 17, 2016

Stress test showing current version of test is flaky on win10: 15 failures in 100 runs

Stress test showing the version in this PR is not flaky on win10: 0 failures in 100 runs

Output showing the version in this PR fails as expected with Node.js 5.3.0:

$ nvm use 5.3
Now using node v5.3.0
$ node -v
v5.3.0
$ node test/parallel/test-debug-no-context.js 

assert.js:89
  throw new assert.AssertionError({
  ^
AssertionError: 'SIGSEGV' === null
    at ChildProcess.<anonymous> (/Users/trott/io.js/test/parallel/test-debug-no-context.js:18:10)
    at ChildProcess.<anonymous> (/Users/trott/io.js/test/common.js:382:15)
    at emitTwo (events.js:87:13)
    at ChildProcess.emit (events.js:172:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
$ 

Output showing the version in this PR passes as expected with Node.js 5.4.0:

$ nvm use 5.4.0
Now using node v5.4.0
$ node -v
v5.4.0
$ node test/parallel/test-debug-no-context.js 
$
@Trott

This comment has been minimized.

Copy link
Member Author

commented Feb 17, 2016

@jasnell

This comment has been minimized.

Copy link
Member

commented Feb 17, 2016

LGTM
@Trott: I assume this is not relevant for v4? If not, can you add the don't land label? :-)

@Trott

This comment has been minimized.

Copy link
Member Author

commented Feb 17, 2016

@jasnell Actually, it is relevant. My mistake not labeling it. I've added lts-watch-4.x label.

@jasnell

This comment has been minimized.

Copy link
Member

commented Feb 17, 2016

Thank you! :-)

Trott added a commit to Trott/io.js that referenced this pull request Feb 19, 2016

test: mitigate flaky test-debug-no-context
Change test so that it passes on the occasional win10 access violation.

The workaround here can be undone when issue 5268 is resolved.

The test still detects the defect it was written to detect. There are
two assertions that detect the defect and only one was disabled.

Ref: nodejs#5268
Fixes: nodejs#4343
PR-URL: nodejs#5269
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member Author

commented Feb 19, 2016

Landed in c4b5a45

@Trott Trott closed this Feb 19, 2016

Trott added a commit to Trott/io.js that referenced this pull request Feb 19, 2016

test: remove flaky mark for test-debug-no-context
test-debug-no-context flakiness was worked around in issue 5269 but the
flaky designation was left for the test. This change removes it.

Refs: nodejs#5269

jasnell added a commit that referenced this pull request Feb 19, 2016

test: remove flaky mark for test-debug-no-context
test-debug-no-context flakiness was worked around in issue 5269 but the
flaky designation was left for the test. This change removes it.

Refs: #5269
PR-URL: #5317
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

rvagg added a commit that referenced this pull request Feb 21, 2016

test: mitigate flaky test-debug-no-context
Change test so that it passes on the occasional win10 access violation.

The workaround here can be undone when issue 5268 is resolved.

The test still detects the defect it was written to detect. There are
two assertions that detect the defect and only one was disabled.

Ref: #5268
Fixes: #4343
PR-URL: #5269
Reviewed-By: James M Snell <jasnell@gmail.com>

rvagg added a commit that referenced this pull request Feb 21, 2016

test: remove flaky mark for test-debug-no-context
test-debug-no-context flakiness was worked around in issue 5269 but the
flaky designation was left for the test. This change removes it.

Refs: #5269
PR-URL: #5317
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Mar 1, 2016

test: mitigate flaky test-debug-no-context
Change test so that it passes on the occasional win10 access violation.

The workaround here can be undone when issue 5268 is resolved.

The test still detects the defect it was written to detect. There are
two assertions that detect the defect and only one was disabled.

Ref: #5268
Fixes: #4343
PR-URL: #5269
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Mar 1, 2016

test: remove flaky mark for test-debug-no-context
test-debug-no-context flakiness was worked around in issue 5269 but the
flaky designation was left for the test. This change removes it.

Refs: #5269
PR-URL: #5317
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Mar 1, 2016

test: mitigate flaky test-debug-no-context
Change test so that it passes on the occasional win10 access violation.

The workaround here can be undone when issue 5268 is resolved.

The test still detects the defect it was written to detect. There are
two assertions that detect the defect and only one was disabled.

Ref: #5268
Fixes: #4343
PR-URL: #5269
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Mar 1, 2016

test: remove flaky mark for test-debug-no-context
test-debug-no-context flakiness was worked around in issue 5269 but the
flaky designation was left for the test. This change removes it.

Refs: #5269
PR-URL: #5317
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Mar 2, 2016

test: mitigate flaky test-debug-no-context
Change test so that it passes on the occasional win10 access violation.

The workaround here can be undone when issue 5268 is resolved.

The test still detects the defect it was written to detect. There are
two assertions that detect the defect and only one was disabled.

Ref: #5268
Fixes: #4343
PR-URL: #5269
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Mar 2, 2016

test: remove flaky mark for test-debug-no-context
test-debug-no-context flakiness was worked around in issue 5269 but the
flaky designation was left for the test. This change removes it.

Refs: #5269
PR-URL: #5317
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.