New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc, installer: win - new logo in installer; optim .jpg #5531

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@eljefedelrodeodeljefe
Contributor

eljefedelrodeodeljefe commented Mar 2, 2016

Pull Request check-list

Please make sure to review and check all of these items:

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

tools

Description of change

Latest logo iteration makes image adaptation necessary, #5381.
I couldn't get wix or VS to run properly (new to windows dev), but according to what I see in the installer and read in the wix project, this should suffice.

had to close #5391 and reopen here due to rebase foo and GH not being able to reopen closed force-pushed branches. Sorry.

/cc @rvagg can you give Jenkins a try? Could build locally.

@rvagg

This comment has been minimized.

Show comment
Hide comment
@rvagg

rvagg Mar 3, 2016

Member

https://nodejs.org/download/test/v6.0.0-test20160303761abde90c/

I don't have a Windows machine or VM handy right now to test so could you screenshot both the x86 and x64 installers and post them here please @eljefedelrodeodeljefe?

Member

rvagg commented Mar 3, 2016

https://nodejs.org/download/test/v6.0.0-test20160303761abde90c/

I don't have a Windows machine or VM handy right now to test so could you screenshot both the x86 and x64 installers and post them here please @eljefedelrodeodeljefe?

@eljefedelrodeodeljefe

This comment has been minimized.

Show comment
Hide comment
@eljefedelrodeodeljefe

eljefedelrodeodeljefe Mar 3, 2016

Contributor

On parallels, Win10:

x64
node_js_setup
node_js_setup

x86
node_js_setup
node_js_setup

Contributor

eljefedelrodeodeljefe commented Mar 3, 2016

On parallels, Win10:

x64
node_js_setup
node_js_setup

x86
node_js_setup
node_js_setup

@rvagg

This comment has been minimized.

Show comment
Hide comment
@rvagg

rvagg Mar 3, 2016

Member

Nice, my only question now is whether we should change the Node green bar at the top to match the new style. @nodejs/website can you please look at the above screenshots and tell us if they are acceptable or should we move the strip of green at the top to a different colour, and if so, what colour?

Member

rvagg commented Mar 3, 2016

Nice, my only question now is whether we should change the Node green bar at the top to match the new style. @nodejs/website can you please look at the above screenshots and tell us if they are acceptable or should we move the strip of green at the top to a different colour, and if so, what colour?

@joaocgreis

This comment has been minimized.

Show comment
Hide comment
@joaocgreis

joaocgreis Mar 3, 2016

Member

Tested both installers on Windows 2008 R2, both look fine, as the screenshots above for Windows 10.

Member

joaocgreis commented Mar 3, 2016

Tested both installers on Windows 2008 R2, both look fine, as the screenshots above for Windows 10.

doc, installer: win - new logo in installer; optim .jpg
doc, installer: change stripe color to RGB 68 136 62
@eljefedelrodeodeljefe

This comment has been minimized.

Show comment
Hide comment
@eljefedelrodeodeljefe

eljefedelrodeodeljefe Mar 4, 2016

Contributor

Changed the color to the middle tone. See RGB in commit. Squashed the thing.

@rvagg When you decide to land this, I'd actually propose on a separate issue to redesign the installer to something more win10 "tile"-like design. Something that might be nice on my quest for a better win dev UX. Maybe then someone wants to throw in some design ideas.

Contributor

eljefedelrodeodeljefe commented Mar 4, 2016

Changed the color to the middle tone. See RGB in commit. Squashed the thing.

@rvagg When you decide to land this, I'd actually propose on a separate issue to redesign the installer to something more win10 "tile"-like design. Something that might be nice on my quest for a better win dev UX. Maybe then someone wants to throw in some design ideas.

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Mar 4, 2016

Member

Could you make sure to run the image though imageoptim / optipng (also for jpeg) or similar tools? (Make sure you don't loose quality though)

Member

Fishrock123 commented Mar 4, 2016

Could you make sure to run the image though imageoptim / optipng (also for jpeg) or similar tools? (Make sure you don't loose quality though)

@eljefedelrodeodeljefe

This comment has been minimized.

Show comment
Hide comment
@eljefedelrodeodeljefe

eljefedelrodeodeljefe Mar 4, 2016

Contributor

ran it through imageoptim. Do you see anything specific?

Contributor

eljefedelrodeodeljefe commented Mar 4, 2016

ran it through imageoptim. Do you see anything specific?

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Mar 4, 2016

Member

No I just wanted to make sure, less binary bytes in git.

Member

Fishrock123 commented Mar 4, 2016

No I just wanted to make sure, less binary bytes in git.

@eljefedelrodeodeljefe

This comment has been minimized.

Show comment
Hide comment
@eljefedelrodeodeljefe

eljefedelrodeodeljefe Mar 4, 2016

Contributor

Ah, alright. FYI It's 7 and 9kb now, with 9-14% optimization. When I did it with .png it was even over 30%.

Contributor

eljefedelrodeodeljefe commented Mar 4, 2016

Ah, alright. FYI It's 7 and 9kb now, with 9-14% optimization. When I did it with .png it was even over 30%.

@ChALkeR

This comment has been minimized.

Show comment
Hide comment
@ChALkeR

ChALkeR Mar 5, 2016

Member

@Fishrock123 Btw, just running optipng does not give the best result. Even running plain simple advdef afterwards saves a few more bytes. Note that advdef is not even a png optimizer, it does not touch the internal png structure. It just recompresses things.

Member

ChALkeR commented Mar 5, 2016

@Fishrock123 Btw, just running optipng does not give the best result. Even running plain simple advdef afterwards saves a few more bytes. Note that advdef is not even a png optimizer, it does not touch the internal png structure. It just recompresses things.

@silverwind

This comment has been minimized.

Show comment
Hide comment
@silverwind

silverwind Mar 5, 2016

Contributor

LGTM

Contributor

silverwind commented Mar 5, 2016

LGTM

@rvagg

This comment has been minimized.

Show comment
Hide comment
@rvagg

rvagg Mar 7, 2016

Member

lgtm

landed @ 44c9751 thanks @eljefedelrodeodeljefe

Member

rvagg commented Mar 7, 2016

lgtm

landed @ 44c9751 thanks @eljefedelrodeodeljefe

@rvagg rvagg closed this Mar 7, 2016

rvagg added a commit that referenced this pull request Mar 7, 2016

build: update Node.js logo on Win installer
also change stripe color to RGB 68 136 62

PR-URL: #5531
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>

@Fishrock123 Fishrock123 referenced this pull request Mar 7, 2016

Merged

v5.8.0 proposal #5559

Fishrock123 added a commit that referenced this pull request Mar 8, 2016

build: update Node.js logo on Win installer
also change stripe color to RGB 68 136 62

PR-URL: #5531
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>

Fishrock123 added a commit that referenced this pull request Mar 8, 2016

build: update Node.js logo on Win installer
also change stripe color to RGB 68 136 62

PR-URL: #5531
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>

MylesBorins added a commit that referenced this pull request Mar 17, 2016

build: update Node.js logo on Win installer
also change stripe color to RGB 68 136 62

PR-URL: #5531
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>

MylesBorins added a commit that referenced this pull request Mar 21, 2016

build: update Node.js logo on Win installer
also change stripe color to RGB 68 136 62

PR-URL: #5531
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>

MylesBorins added a commit that referenced this pull request Mar 21, 2016

build: update Node.js logo on Win installer
also change stripe color to RGB 68 136 62

PR-URL: #5531
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>

@MylesBorins MylesBorins referenced this pull request Mar 21, 2016

Merged

V4.4.1 proposal #5835

MylesBorins added a commit that referenced this pull request Mar 21, 2016

2016-03-21, Version v4.4.1 'Argon' (LTS)
This LTS release comes with 113 commits, 56 of which are doc related,
18 of which are build / tooling related, 16 of which are test related
and 7 which are benchmark related.

Notable Changes:

* build:
  - Updated Logos for the OSX + Windows installers
    - (Rod Vagg) #5401
    - (Robert Jefe Lindstaedt) #5531
  - New option to select you VS Version in the Windows installer
    - (julien.waechter) #4645
  - Support Visual C++ Build Tools 2015
    - (João Reis) #5627
* tools:
  - Gyp now works on OSX without XCode
    - (Shigeki Ohtsu) #1325

MylesBorins added a commit that referenced this pull request Mar 22, 2016

2016-03-22, Version v4.4.1 'Argon' (LTS)
This LTS release comes with 113 commits, 56 of which are doc related,
18 of which are build / tooling related, 16 of which are test related
and 7 which are benchmark related.

Notable Changes:

* build:
  - Updated Logos for the OSX + Windows installers
    - (Rod Vagg) #5401
    - (Robert Jefe Lindstaedt) #5531
  - New option to select your VS Version in the Windows installer
    - (julien.waechter) #4645
  - Support Visual C++ Build Tools 2015
    - (João Reis) #5627
* tools:
  - Gyp now works on OSX without XCode
    - (Shigeki Ohtsu) #1325

MylesBorins added a commit that referenced this pull request Mar 22, 2016

2016-03-22, Version v4.4.1 'Argon' (LTS)
This LTS release comes with 113 commits, 56 of which are doc related,
18 of which are build / tooling related, 16 of which are test related
and 7 which are benchmark related.

Notable Changes:

* build:
  - Updated Logos for the OSX + Windows installers
    - (Rod Vagg) #5401
    - (Robert Jefe Lindstaedt) #5531
  - New option to select your VS Version in the Windows installer
    - (julien.waechter) #4645
  - Support Visual C++ Build Tools 2015
    - (João Reis) #5627
* tools:
  - Gyp now works on OSX without XCode
    - (Shigeki Ohtsu) #1325

PR-URL: #5835
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment