Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
doc, installer: win - new logo in installer; optim .jpg #5531
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
Affected core subsystem(s)
Description of change
Latest logo iteration makes image adaptation necessary, #5381.
had to close #5391 and reopen here due to rebase foo and GH not being able to reopen closed force-pushed branches. Sorry.
/cc @rvagg can you give Jenkins a try? Could build locally.
I don't have a Windows machine or VM handy right now to test so could you screenshot both the x86 and x64 installers and post them here please @eljefedelrodeodeljefe?
Nice, my only question now is whether we should change the Node green bar at the top to match the new style. @nodejs/website can you please look at the above screenshots and tell us if they are acceptable or should we move the strip of green at the top to a different colour, and if so, what colour?
Changed the color to the middle tone. See RGB in commit. Squashed the thing.
@rvagg When you decide to land this, I'd actually propose on a separate issue to redesign the installer to something more win10 "tile"-like design. Something that might be nice on my quest for a better win dev UX. Maybe then someone wants to throw in some design ideas.