Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: move typescript support to active development #55536

Merged
merged 1 commit into from
Oct 27, 2024
Merged

doc: move typescript support to active development #55536

merged 1 commit into from
Oct 27, 2024
+6 −6

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Oct 25, 2024 •
edited
Loading

--experimental-strip-types has been released for almost ~3 months.
There is only one issue open and TypeScript has created a flag for compatibility with our implementation.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/typescript

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 25, 2024
@anonrig
Copy link
Member

anonrig commented Oct 25, 2024

Is this a semver-minor change?

@marco-ippolito
Copy link
Member Author

Is this a semver-minor change?

Not sure, I dont think so

mcollina
mcollina approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marco-ippolito marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 25, 2024
@marco-ippolito
Copy link
Member Author

marco-ippolito commented Oct 25, 2024 •
edited
Loading

So I had a look at previous graduation PRs and some of them were marked as semver minor, some were not. I think Id rather have it highlighted in the release notes. Its not specified in the doc

@marco-ippolito marco-ippolito added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 25, 2024
@RedYetiDev RedYetiDev added experimental Issues and PRs related to experimental features. strip-types Issues or PRs related to strip-types support labels Oct 25, 2024
@aduh95
Copy link
Contributor

aduh95 commented Oct 26, 2024

So I had a look at previous graduation PRs and some of them were marked as semver minor, some were not. I think Id rather have it highlighted in the release notes. Its not specified in the doc

I don’t think it’s semver-minor, but we can label it as a notable change if we think it deserves to be highlighted

@aduh95 aduh95 added notable-change PRs with changes that should be highlighted in changelogs. and removed semver-minor PRs that contain new features and should be released in the next minor version. labels Oct 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @aduh95.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2024
@nodejs-github-bot nodejs-github-bot merged commit 2a96549 into nodejs:main Oct 27, 2024
42 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 2a96549

RafaelGSS pushed a commit that referenced this pull request Nov 1, 2024
@marco-ippolito @RafaelGSS
doc: move typescript support to active development
fa61dce 
PR-URL: #55536
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
RafaelGSS added a commit to RafaelGSS/node that referenced this pull request Nov 1, 2024
@RafaelGSS
2024-11-01, Version 23.2.0 (Current)
736f2f1 
Notable changes:

doc:
  * move typescript support to active development (Marco Ippolito) nodejs#55536
  * add jazelly to collaborators (Jason Zhang) nodejs#55531
fs:
  * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) nodejs#55547
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) nodejs#55586
module:
  * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) nodejs#55412
  * (SEMVER-MINOR) add module.stripTypeScriptTypes (Marco Ippolito) nodejs#55282

PR-URL: TODO
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@marco-ippolito @louwers
doc: move typescript support to active development
c6262fb 
PR-URL: nodejs#55536
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 added a commit that referenced this pull request Nov 6, 2024
@aduh95
2024-11-07, Version 23.2.0 (Current)
b40f681 
Notable changes:

crypto:
  * update root certificates to NSS 3.104 (Richard Lau) #55681
doc:
  * move typescript support to active development (Marco Ippolito) #55536
  * add jazelly to collaborators (Jason Zhang) #55531
fs:
  * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586
module:
  * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412
  * (SEMVER-MINOR) add module.stripTypeScriptTypes (Marco Ippolito) #55282
tools:
  * fix root certificate updater (Richard Lau) #55681

PR-URL: TODO
@aduh95 aduh95 mentioned this pull request Nov 6, 2024
Merged
aduh95 added a commit that referenced this pull request Nov 6, 2024
@aduh95
2024-11-07, Version 23.2.0 (Current)
2c07f86 
Notable changes:

crypto:
  * update root certificates to NSS 3.104 (Richard Lau) #55681
doc:
  * move typescript support to active development (Marco Ippolito) #55536
  * add jazelly to collaborators (Jason Zhang) #55531
fs:
  * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586
module:
  * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412
  * (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) #55282

PR-URL: #55741
aduh95 added a commit that referenced this pull request Nov 6, 2024
@aduh95
2024-11-07, Version 23.2.0 (Current)
69c6bf2 
Notable changes:

crypto:
  * update root certificates to NSS 3.104 (Richard Lau) #55681
doc:
  * move typescript support to active development (Marco Ippolito) #55536
  * add jazelly to collaborators (Jason Zhang) #55531
fs:
  * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586
module:
  * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412
  * (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) #55282

PR-URL: #55741
aduh95 added a commit that referenced this pull request Nov 9, 2024
@aduh95
2024-11-11, Version 23.2.0 (Current)
f2bac99 
Notable changes:

crypto:
  * update root certificates to NSS 3.104 (Richard Lau) #55681
doc:
  * move typescript support to active development (Marco Ippolito) #55536
  * add jazelly to collaborators (Jason Zhang) #55531
fs:
  * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586
module:
  * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412
  * (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) #55282

PR-URL: #55741
aduh95 added a commit that referenced this pull request Nov 11, 2024
@aduh95
2024-11-11, Version 23.2.0 (Current)
a83fbdb 
Notable changes:

crypto:
  * update root certificates to NSS 3.104 (Richard Lau) #55681
doc:
  * move typescript support to active development (Marco Ippolito) #55536
  * add jazelly to collaborators (Jason Zhang) #55531
fs:
  * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586
module:
  * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412
  * (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) #55282

PR-URL: #55741
aduh95 added a commit that referenced this pull request Nov 11, 2024
@aduh95
2024-11-11, Version 23.2.0 (Current)
c52c670 
Notable changes:

crypto:
  * update root certificates to NSS 3.104 (Richard Lau) #55681
doc:
  * move typescript support to active development (Marco Ippolito) #55536
  * add jazelly to collaborators (Jason Zhang) #55531
fs:
  * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586
module:
  * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412
  * (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) #55282

PR-URL: #55741
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@marco-ippolito @tpoisseau
doc: move typescript support to active development
2251044 
PR-URL: nodejs#55536
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@aduh95 @tpoisseau
2024-11-11, Version 23.2.0 (Current)
f802d96 
Notable changes:

crypto:
  * update root certificates to NSS 3.104 (Richard Lau) nodejs#55681
doc:
  * move typescript support to active development (Marco Ippolito) nodejs#55536
  * add jazelly to collaborators (Jason Zhang) nodejs#55531
fs:
  * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) nodejs#55547
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) nodejs#55586
module:
  * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) nodejs#55412
  * (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) nodejs#55282

PR-URL: nodejs#55741
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Nov 26, 2024
@aduh95 @Ceres6
2024-11-11, Version 23.2.0 (Current)
04ed125 
Notable changes:

crypto:
  * update root certificates to NSS 3.104 (Richard Lau) nodejs#55681
doc:
  * move typescript support to active development (Marco Ippolito) nodejs#55536
  * add jazelly to collaborators (Jason Zhang) nodejs#55531
fs:
  * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) nodejs#55547
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) nodejs#55586
module:
  * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) nodejs#55412
  * (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) nodejs#55282

PR-URL: nodejs#55741
@ruyadorno
Copy link
Member

This commit does not land cleanly on v22.x-staging and will need manual backport in case we want it in v22.x.

@ruyadorno ruyadorno added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

@mertcanaltin mertcanaltin mertcanaltin approved these changes

@MoLow MoLow MoLow approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@anonrig anonrig anonrig approved these changes

@styfle styfle styfle approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. doc Issues and PRs related to the documentations. experimental Issues and PRs related to experimental features. notable-change PRs with changes that should be highlighted in changelogs. strip-types Issues or PRs related to strip-types support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.