Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
src,http: fix uncaughtException miss in http #5591
In AsyncWrap::MakeCallback always return empty handle if there is an
The HTTParser call to AsyncWrap::MakeCallback failed because it expected
In node::MakeCallback return an empty handle if the call is
Follow up from #5571 where was decided patch would land on master first.
referenced this pull request
Mar 7, 2016
@trevnorris Do we want to handle both cases (being in a recursive
Another case I missed to mention is https://github.com/nodejs/node/blob/master/src/async-wrap.cc#L196. I don't have the time to create a repro for that use case, but I'd imagine it would be possible to write one that exposes a problem where a callback executed by
What do you think?