Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make test-net-connect-options-ipv6.js better #5791

Closed
wants to merge 1 commit into from

Conversation

@mhdawson
Copy link
Member

commented Mar 18, 2016

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?

Affected core subsystem(s)

test

Description of change

Improve the robustness of test-net-connect-options-ipv6.js

PPC suse build team encountered intermittent failures related
to dns. Improve test to make it more robust in the face
of intermittent dns issues.

@mhdawson mhdawson added the test label Mar 18, 2016

@jasnell

This comment has been minimized.

Copy link
Member

commented Mar 18, 2016

LGTM

@mscdex mscdex added the net label Mar 18, 2016

@Trott

This comment has been minimized.

Copy link
Member

commented Mar 19, 2016

@mhdawson

This comment has been minimized.

Copy link
Member Author

commented Mar 21, 2016

test: make test-net-connect-options-ipv6.js better
improve the robustness of test-net-connect-options-ipv6.js

PPC Suse build team encountered intermittent failures related
to dns.  Improve test to make it more robust in the face
of intermittent dns issues.

@mhdawson mhdawson force-pushed the mhdawson:susetest branch to c25b865 Mar 21, 2016

mhdawson added a commit that referenced this pull request Mar 21, 2016
test: make test-net-connect-options-ipv6.js better
Improve the robustness of test-net-connect-options-ipv6.js

PPC Suse build team encountered intermittent failures related
to dns.  Improve test to make it more robust in the face
of intermittent dns issues.

PR-URL: #5791
Reviewed-By: James M Snell <jasnell@gmail.com>
@mhdawson

This comment has been minimized.

Copy link
Member Author

commented Mar 21, 2016

Landed as 287bdab

@mhdawson mhdawson closed this Mar 21, 2016

Fishrock123 added a commit that referenced this pull request Mar 22, 2016
test: make test-net-connect-options-ipv6.js better
Improve the robustness of test-net-connect-options-ipv6.js

PPC Suse build team encountered intermittent failures related
to dns.  Improve test to make it more robust in the face
of intermittent dns issues.

PR-URL: #5791
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request Mar 30, 2016
test: make test-net-connect-options-ipv6.js better
Improve the robustness of test-net-connect-options-ipv6.js

PPC Suse build team encountered intermittent failures related
to dns.  Improve test to make it more robust in the face
of intermittent dns issues.

PR-URL: #5791
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request Mar 30, 2016
test: make test-net-connect-options-ipv6.js better
Improve the robustness of test-net-connect-options-ipv6.js

PPC Suse build team encountered intermittent failures related
to dns.  Improve test to make it more robust in the face
of intermittent dns issues.

PR-URL: #5791
Reviewed-By: James M Snell <jasnell@gmail.com>

@mhdawson mhdawson deleted the mhdawson:susetest branch Mar 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.