New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add failing url parse tests as known_issue #5885

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@jasnell
Member

jasnell commented Mar 24, 2016

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

Affected core subsystem(s)

url, test

Description of change

url resolve and parse do not currently adhere to the same url spec parsing rules that browsers use, which leads to some issues. This addition to test/known_issues creates a set of tests based on the w3c/whatwg test suite from https://github.com/w3c/web-platform-tests/tree/master/url

@@ -0,0 +1,52 @@
'use strict';

This comment has been minimized.

@cjihrig

cjihrig Mar 24, 2016

Contributor

Are there any specific issues that can be Refs:'ed here?

@cjihrig

cjihrig Mar 24, 2016

Contributor

Are there any specific issues that can be Refs:'ed here?

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Mar 24, 2016

Contributor

LGTM

Contributor

cjihrig commented Mar 24, 2016

LGTM

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 24, 2016

Member

@cjihrig .. updated, PTAL
/cc @nodejs/testing

Member

jasnell commented Mar 24, 2016

@cjihrig .. updated, PTAL
/cc @nodejs/testing

@sam-github

This comment has been minimized.

Show comment
Hide comment
@sam-github

sam-github Apr 1, 2016

Member

@jasnell is there a list of defects?

Member

sam-github commented Apr 1, 2016

@jasnell is there a list of defects?

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Apr 1, 2016

Member

#5832 is one. I don't have a compiled list tho.

Member

jasnell commented Apr 1, 2016

#5832 is one. I don't have a compiled list tho.

@sam-github

This comment has been minimized.

Show comment
Hide comment
@sam-github

sam-github Apr 1, 2016

Member

I was wondering if you found more things than I reported.

Member

sam-github commented Apr 1, 2016

I was wondering if you found more things than I reported.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Apr 1, 2016

Member

Well, the test points out that there are a significant number of inconsistencies between our parsing (and relative URL resolution) than what is implemented / expected on the browser side per the WhatWG specs. This test is really meant just to highlight those. I wouldn't necessarily call them defects, per se, but closing the gaps would be good.

Member

jasnell commented Apr 1, 2016

Well, the test points out that there are a significant number of inconsistencies between our parsing (and relative URL resolution) than what is implemented / expected on the browser side per the WhatWG specs. This test is really meant just to highlight those. I wouldn't necessarily call them defects, per se, but closing the gaps would be good.

@jasnell jasnell added the in progress label Apr 22, 2016

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell May 1, 2016

Member

Updated. /cc @cjihrig @mscdex

Member

jasnell commented May 1, 2016

Updated. /cc @cjihrig @mscdex

test: add failing url parse tests as known_issue
url resolve and parse do not currently adhere to the same url
spec parsing rules that browsers use, which leads to some
issues. This addition to test/known_issues creates a set of
tests based on the w3c/whatwg test suite from:

https://github.com/w3c/web-platform-tests/tree/master/url
@mscdex

This comment has been minimized.

Show comment
Hide comment
@mscdex

mscdex May 1, 2016

Contributor

LGTM

Contributor

mscdex commented May 1, 2016

LGTM

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig May 2, 2016

Contributor

LGTM

Contributor

cjihrig commented May 2, 2016

LGTM

jasnell added a commit that referenced this pull request May 2, 2016

test: add failing url parse tests as known_issue
url resolve and parse do not currently adhere to the same url
spec parsing rules that browsers use, which leads to some
issues. This addition to test/known_issues creates a set of
tests based on the w3c/whatwg test suite from:

Refs: https://github.com/w3c/web-platform-tests/tree/master/url

PR-URL: #5885
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell May 2, 2016

Member

Landed in fa542eb. Thanks @mscdex and @cjihrig !

Member

jasnell commented May 2, 2016

Landed in fa542eb. Thanks @mscdex and @cjihrig !

@jasnell jasnell closed this May 2, 2016

Fishrock123 added a commit that referenced this pull request May 4, 2016

test: add failing url parse tests as known_issue
url resolve and parse do not currently adhere to the same url
spec parsing rules that browsers use, which leads to some
issues. This addition to test/known_issues creates a set of
tests based on the w3c/whatwg test suite from:

Refs: https://github.com/w3c/web-platform-tests/tree/master/url

PR-URL: #5885
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>

joelostrowski added a commit to joelostrowski/node that referenced this pull request May 4, 2016

test: add failing url parse tests as known_issue
url resolve and parse do not currently adhere to the same url
spec parsing rules that browsers use, which leads to some
issues. This addition to test/known_issues creates a set of
tests based on the w3c/whatwg test suite from:

Refs: https://github.com/w3c/web-platform-tests/tree/master/url

PR-URL: nodejs#5885
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Jun 1, 2016

Member

Added don't land as I'm assuming we would not be chasing down this problem in lts

Member

MylesBorins commented Jun 1, 2016

Added don't land as I'm assuming we would not be chasing down this problem in lts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment