Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dgram: pass null as error on successful send() #5929

Merged
merged 1 commit into from Mar 28, 2016

Conversation

Projects
None yet
4 participants
@cjihrig
Copy link
Contributor

commented Mar 28, 2016

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

Affected core subsystem(s)

dgram

Description of change

Prior to c9fd9e2, UDP sockets would callback with a null error on successful send() calls. The current behavior is to pass 0 as the error. This commit restores the previous, more expected behavior.

@evanlucas

This comment has been minimized.

Copy link
Member

commented Mar 28, 2016

LGTM if CI is happy

@Trott

This comment has been minimized.

Copy link
Member

commented Mar 28, 2016

LGTM if CI doesn't reveal anything interesting

@mscdex

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2016

dgram: pass null as error on successful send()
Prior to c9fd9e2, UDP sockets
would callback with a null error on successful send() calls. The
current behavior is to pass 0 as the error. This commit restores
the previous, more expected behavior.

PR-URL: #5929
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>

@cjihrig cjihrig force-pushed the cjihrig:send-err branch to 4bc1ccc Mar 28, 2016

@cjihrig cjihrig merged commit 4bc1ccc into nodejs:master Mar 28, 2016

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2016

Thanks for the reviews. Landed in 4bc1ccc.

@cjihrig cjihrig deleted the cjihrig:send-err branch Mar 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.