From fdfe0505dac727704bf87dae9c7fe0f5a7393e97 Mon Sep 17 00:00:00 2001 From: Alex Yang Date: Thu, 7 Aug 2025 17:11:16 -0700 Subject: [PATCH 1/2] sqlite: add sqlite-type symbol for DatabaseSync --- src/node_sqlite.cc | 6 ++++++ test/parallel/test-sqlite-database-sync.js | 9 +++++++++ 2 files changed, 15 insertions(+) diff --git a/src/node_sqlite.cc b/src/node_sqlite.cc index 3a7c39e72cf421..f6ccbf531f494f 100644 --- a/src/node_sqlite.cc +++ b/src/node_sqlite.cc @@ -2758,6 +2758,12 @@ static void Initialize(Local target, db_tmpl, FIXED_ONE_BYTE_STRING(isolate, "isTransaction"), DatabaseSync::IsTransactionGetter); + Local sqlite_type_key = FIXED_ONE_BYTE_STRING(isolate, "sqlite-type"); + Local sqlite_type_symbol = + v8::Symbol::For(isolate, sqlite_type_key); + Local database_sync_string = FIXED_ONE_BYTE_STRING(isolate, "node:sqlite"); + db_tmpl->InstanceTemplate()->Set(sqlite_type_symbol, database_sync_string); + SetConstructorFunction(context, target, "DatabaseSync", db_tmpl); SetConstructorFunction(context, target, diff --git a/test/parallel/test-sqlite-database-sync.js b/test/parallel/test-sqlite-database-sync.js index 5b34dec4cc220f..d778f839098737 100644 --- a/test/parallel/test-sqlite-database-sync.js +++ b/test/parallel/test-sqlite-database-sync.js @@ -281,6 +281,15 @@ suite('DatabaseSync() constructor', () => { { changes: 1, lastInsertRowid: 1 }, ); }); + + test('has sqlite-type symbol property', (t) => { + const dbPath = nextDb(); + const db = new DatabaseSync(dbPath); + t.after(() => { db.close(); }); + + const sqliteTypeSymbol = Symbol.for('sqlite-type'); + t.assert.strictEqual(db[sqliteTypeSymbol], 'node:sqlite'); + }); }); suite('DatabaseSync.prototype.open()', () => { From 0ddc06bf2624af750877afcc21d7aaef9e5a457c Mon Sep 17 00:00:00 2001 From: Alex Yang Date: Mon, 18 Aug 2025 08:44:20 -0700 Subject: [PATCH 2/2] fixup! sqlite: add sqlite-type symbol for DatabaseSync --- src/node_sqlite.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/node_sqlite.cc b/src/node_sqlite.cc index f6ccbf531f494f..a44c9506ce9052 100644 --- a/src/node_sqlite.cc +++ b/src/node_sqlite.cc @@ -2761,7 +2761,8 @@ static void Initialize(Local target, Local sqlite_type_key = FIXED_ONE_BYTE_STRING(isolate, "sqlite-type"); Local sqlite_type_symbol = v8::Symbol::For(isolate, sqlite_type_key); - Local database_sync_string = FIXED_ONE_BYTE_STRING(isolate, "node:sqlite"); + Local database_sync_string = + FIXED_ONE_BYTE_STRING(isolate, "node:sqlite"); db_tmpl->InstanceTemplate()->Set(sqlite_type_symbol, database_sync_string); SetConstructorFunction(context, target, "DatabaseSync", db_tmpl);