Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove deprecated internal functions #6053

Merged

Conversation

Projects
None yet
5 participants
@bnoordhuis
Copy link
Member

commented Apr 5, 2016

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

Affected core subsystem(s)

src

Description of change

  • src: remove deprecated internal functions

CI: https://ci.nodejs.org/job/node-test-pull-request/2158/

@benjamingr

This comment has been minimized.

Copy link
Member

commented Apr 5, 2016

This is for 6.0?

LGTM I guess, pretty straightforward changes :)

@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2016

LGTM and CI is green.

@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 5, 2016

LGTM

src: remove deprecated internal functions
PR-URL: #6053
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@bnoordhuis bnoordhuis force-pushed the bnoordhuis:remove-deprecated-internal-functions branch to 757fbac Apr 5, 2016

@bnoordhuis bnoordhuis closed this Apr 5, 2016

@bnoordhuis bnoordhuis deleted the bnoordhuis:remove-deprecated-internal-functions branch Apr 5, 2016

@bnoordhuis bnoordhuis merged commit 757fbac into nodejs:master Apr 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.