From ff0e79d533f226ac89b7454636147a7c65d8c74d Mon Sep 17 00:00:00 2001 From: Sebastian Beltran Date: Sat, 8 Nov 2025 14:17:46 +0000 Subject: [PATCH] http: move writeHeader to end-of-life --- doc/api/deprecations.md | 5 ++++- lib/_http_server.js | 5 ----- test/parallel/test-write-header.js | 20 -------------------- 3 files changed, 4 insertions(+), 26 deletions(-) delete mode 100644 test/parallel/test-write-header.js diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index 610bcc4f7302a1..95a237326f7f49 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -1600,6 +1600,9 @@ instead. -Type: Runtime +Type: End-of-Life The `node:http` module `ServerResponse.prototype.writeHeader()` API is deprecated. Please use `ServerResponse.prototype.writeHead()` instead. diff --git a/lib/_http_server.js b/lib/_http_server.js index 3fd14faedf46d8..9df050e84289ae 100644 --- a/lib/_http_server.js +++ b/lib/_http_server.js @@ -84,7 +84,6 @@ const { } = require('internal/errors'); const { assignFunctionName, - deprecate, kEmptyObject, promisify, } = require('internal/util'); @@ -447,10 +446,6 @@ function writeHead(statusCode, reason, obj) { return this; } -ServerResponse.prototype.writeHeader = deprecate(ServerResponse.prototype.writeHead, - 'ServerResponse.prototype.writeHeader is deprecated.', - 'DEP0063'); - function storeHTTPOptions(options) { this[kIncomingMessage] = options.IncomingMessage || IncomingMessage; this[kServerResponse] = options.ServerResponse || ServerResponse; diff --git a/test/parallel/test-write-header.js b/test/parallel/test-write-header.js deleted file mode 100644 index 38a835bcddbf9c..00000000000000 --- a/test/parallel/test-write-header.js +++ /dev/null @@ -1,20 +0,0 @@ -'use strict'; -const common = require('../common'); -const assert = require('assert'); -const http = require('http'); - -common.expectWarning('DeprecationWarning', - 'ServerResponse.prototype.writeHeader is deprecated.', 'DEP0063'); - -const server = http.createServer(common.mustCall((req, res) => { - res.writeHeader(200, [ 'test', '2', 'test2', '2' ]); - res.end(); -})).listen(0, common.mustCall(() => { - http.get({ port: server.address().port }, common.mustCall((res) => { - assert.strictEqual(res.headers.test, '2'); - assert.strictEqual(res.headers.test2, '2'); - res.resume().on('end', common.mustCall(() => { - server.close(); - })); - })); -}));