module: allow subpath imports that start with `#/` #60864

hybrist · 2025-11-26T19:31:55Z

It's a common ecosystem pattern to map a source root directory to @/ but it requires special tooling support. This turns #/* into a more realistic alternative for that pattern.

See: #49182

It's a common ecosystem pattern to map a source root directory to `@/` but it requires special tooling support. This turns `#/*` into a more realistic alternative for that pattern.

nodejs-github-bot · 2025-11-26T19:32:00Z

Review requested:

@nodejs/loaders
@nodejs/typescript

codecov · 2025-11-26T20:26:14Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.51%. Comparing base (6706b22) to head (9f4d8ec).
⚠️ Report is 56 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #60864      +/-   ##
==========================================
- Coverage   88.54%   88.51%   -0.04%     
==========================================
  Files         703      703              
  Lines      208262   208393     +131     
  Branches    40170    40198      +28     
==========================================
+ Hits       184408   184454      +46     
- Misses      15861    15928      +67     
- Partials     7993     8011      +18

Files with missing lines	Coverage Δ
lib/internal/modules/esm/resolve.js	`96.19% <100.00%> (-0.01%)`	⬇️

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334 · 2025-11-27T21:22:57Z

From the perspective of adding support for a new module resolution flavour to TS et al, should this either be semver-major or >=v25.x-only?

hybrist · 2025-11-27T22:23:53Z

From the perspective of adding support for a new module resolution flavour to TS et al, should this either be semver-major or >=v25.x-only?

Since this only turns a previous import error into a non-error case, this seems safe to backport pretty aggressively. From the TS perspective, I would expect it to show up in the bundler mode eventually? If TS doesn't actively allow it in node20 mode etc. that doesn't seem like a huge issue.

nodejs-github-bot · 2025-12-01T19:02:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70365/

nodejs-github-bot · 2025-12-01T20:13:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70366/

hybrist · 2025-12-01T21:25:37Z

CI is clean. Added a change entry to the docs for subpath imports to track version support for this change.

GeoffreyBooth

I think this is fine, but did we dig up the reason for the exclusion in the first place?

hybrist · 2025-12-02T00:17:23Z

Short answer: no. I did try to look around a bit but I couldn't really find one. The behavior was introduced in the original PR (#34117) and @guybedford's reason seemed to be caution but not necessarily explicit risks:

I thought it seemed sensible to lock down these base cases, but happy to reconsider.

nodejs-github-bot · 2025-12-03T07:32:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70373/

nodejs-github-bot · 2025-12-03T14:20:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70376/

nodejs-github-bot · 2025-12-03T16:33:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70378/

nodejs-github-bot · 2025-12-03T19:46:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70380/

nodejs-github-bot · 2025-12-04T02:27:06Z

Landed in e8c9c43

It's a common ecosystem pattern to map a source root directory to `@/` but it requires special tooling support. This turns `#/*` into a more realistic alternative for that pattern. PR-URL: #60864 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>

This aligns with Node.js PR nodejs/node#60864, which allows defining symmetric `exports` and `imports` fields in package.json: { "exports": { "./*": "./src/*" }, "imports": { "#/*": "./src/*" } }

module: allow subpath imports that start with #/

8eff1ef

It's a common ecosystem pattern to map a source root directory to `@/` but it requires special tooling support. This turns `#/*` into a more realistic alternative for that pattern.

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Nov 26, 2025

guybedford approved these changes Nov 27, 2025

View reviewed changes

hybrist added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 1, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 1, 2025

hybrist added semver-minor PRs that contain new features and should be released in the next minor version. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 1, 2025

hybrist changed the title ~~module: allow internal imports that start with #/~~ module: allow subpath imports that start with #/ Dec 1, 2025

hybrist requested a review from guybedford December 1, 2025 21:24

fixup! module: allow subpath imports that start with #/

9f4d8ec

hybrist force-pushed the focused-mendeleev branch from d3b6ceb to 9f4d8ec Compare December 1, 2025 21:39

GeoffreyBooth approved these changes Dec 1, 2025

View reviewed changes

ovflowd approved these changes Dec 2, 2025

View reviewed changes

himself65 approved these changes Dec 2, 2025

View reviewed changes

gurgunday approved these changes Dec 2, 2025

View reviewed changes

gurgunday added the module Issues and PRs related to the module subsystem. label Dec 2, 2025

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2025

hybrist added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 4, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 4, 2025

nodejs-github-bot merged commit e8c9c43 into nodejs:main Dec 4, 2025
74 of 76 checks passed

hybrist deleted the focused-mendeleev branch December 4, 2025 14:01

This was referenced Dec 5, 2025

allow subpath imports that start with #/ oxc-project/oxc-resolver#904

Closed

Module Resolution: allow subpath imports that start with #/ microsoft/TypeScript#62841

Open

coolaj86 mentioned this pull request Dec 5, 2025

basetag is no longer needed 🎉 janniks/basetag#31

Open

magic-akari mentioned this pull request Dec 6, 2025

Allow subpath imports that start with #/ microsoft/TypeScript#62844

Open

dsherret mentioned this pull request Dec 7, 2025

feat(node): allow subpath imports that start with '#/' denoland/deno#31520

Open

Uh oh!

module: allow subpath imports that start with #/ #60864

module: allow subpath imports that start with #/ #60864

Uh oh!

Conversation

hybrist commented Nov 26, 2025

Uh oh!

nodejs-github-bot commented Nov 26, 2025 • edited by marco-ippolito Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Renegade334 commented Nov 27, 2025

Uh oh!

hybrist commented Nov 27, 2025

Uh oh!

nodejs-github-bot commented Dec 1, 2025

Uh oh!

nodejs-github-bot commented Dec 1, 2025

Uh oh!

hybrist commented Dec 1, 2025

Uh oh!

GeoffreyBooth left a comment

Choose a reason for hiding this comment

Uh oh!

hybrist commented Dec 2, 2025

Uh oh!

nodejs-github-bot commented Dec 3, 2025

Uh oh!

nodejs-github-bot commented Dec 3, 2025

Uh oh!

nodejs-github-bot commented Dec 3, 2025

Uh oh!

nodejs-github-bot commented Dec 3, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Dec 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

module: allow subpath imports that start with `#/` #60864

module: allow subpath imports that start with `#/` #60864

nodejs-github-bot commented Nov 26, 2025 •

edited by marco-ippolito

Loading

codecov bot commented Nov 26, 2025 •

edited

Loading