Skip to content

Conversation

@mertcanaltin
Copy link
Member

added HandleScope to loop in heap_utils

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 28, 2025
@mertcanaltin mertcanaltin marked this pull request as draft November 28, 2025 20:55
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.56%. Comparing base (d1ab5ef) to head (d09922c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #60885   +/-   ##
=======================================
  Coverage   88.55%   88.56%           
=======================================
  Files         703      703           
  Lines      208291   208293    +2     
  Branches    40174    40169    -5     
=======================================
+ Hits       184454   184470   +16     
- Misses      15829    15837    +8     
+ Partials     8008     7986   -22     
Files with missing lines Coverage Δ
src/heap_utils.cc 79.93% <100.00%> (-0.21%) ⬇️

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mertcanaltin mertcanaltin marked this pull request as ready for review November 29, 2025 10:24
@mertcanaltin mertcanaltin force-pushed the mert/add-handle-scope/heap-utils branch from fb6528f to d856e98 Compare November 29, 2025 14:27
@mertcanaltin mertcanaltin force-pushed the mert/add-handle-scope/heap-utils branch from d856e98 to d09922c Compare November 29, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants