Skip to content

Conversation

@Han5991
Copy link
Contributor

@Han5991 Han5991 commented Dec 7, 2025

Fixes: #60952

Reset prevRows for multiline prompts during tab completion so the refresh doesn’t wipe the completion list, and add a regression test
that simulates a multiline prompt to verify completions remain visible

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module. labels Dec 7, 2025
@codecov
Copy link

codecov bot commented Dec 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.51%. Comparing base (37d9cfc) to head (0d63901).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #60981   +/-   ##
=======================================
  Coverage   88.51%   88.51%           
=======================================
  Files         703      703           
  Lines      208430   208433    +3     
  Branches    40198    40208   +10     
=======================================
+ Hits       184491   184504   +13     
- Misses      15951    15953    +2     
+ Partials     7988     7976   -12     
Files with missing lines Coverage Δ
lib/internal/readline/interface.js 97.35% <100.00%> (+<0.01%) ⬆️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[readline] Multiline question eats the output from the completer

2 participants