Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
src,tools: rewrite check-imports and fix linter errors #6105
Affected core subsystem(s)
Description of change
As it is, check-install.sh does not show more helpful error messages,
This patch simply enables check-imports.py in the linting process
Fix all the linter errors
@Fishrock123 Hmmm, weird! I ran the linter locally before pushing. Anyway, I fixed it and the new CI Run (https://ci.nodejs.org/job/node-test-pull-request/2211/) completed linting successfully.
@bnoordhuis The other reason I rewrote it in Python was because, if this is included in the linter, all the development environments are supposed to have sed, grep, sort and etc. That may not be available in all the environments I guess. I am okay with retaining the shell script itself, if possible.