Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gyp: Inherit CC/CXX for CC/CXX.host #6173

Merged
merged 1 commit into from Apr 24, 2016

Conversation

Projects
None yet
7 participants
@jbergstroem
Copy link
Member

commented Apr 13, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

tools/gyp

Description of change

Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++ through CC/CXX, lean against it (then drop to gcc/g++).

I don't think this will be accepted upstream but I guess I should give it a try.

Refs #6088 and fixes #6152.
/cc @srl295, @bnoordhuis.

@jbergstroem

This comment has been minimized.

Copy link
Member Author

commented Apr 13, 2016

CI without custom configure flags:
https://ci.nodejs.org/job/node-test-commit/2900/ (unrelated fail on arm)

CI on FreeBSD with custom configure flags:
https://ci.nodejs.org/job/node-test-commit-freebsd/2043/

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Apr 13, 2016

Can you try upstreaming it first? I don't want us to carry out-of-tree patches unless absolutely necessary.

@jbergstroem

This comment has been minimized.

Copy link
Member Author

commented Apr 13, 2016

@bnoordhuis: That was the plan -- just want to have a better look through their bug trackers first.

@jbergstroem

This comment has been minimized.

Copy link
Member Author

commented Apr 13, 2016

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Apr 13, 2016

Can I suggest you upload the patch with git-cl upload? You'll get an answer quicker that way. CC gyp-developer@googlegroups.com if that isn't filled out automatically by https://codereview.chromium.org/.

@jbergstroem

This comment has been minimized.

Copy link
Member Author

commented Apr 13, 2016

@mscdex mscdex added the build label Apr 13, 2016

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Apr 13, 2016

Maybe assign a reviewer as well. git shortlog -ns for that file suggests that thakis@ is a good choice. git-cl owners can be helpful, too.

@joaocgreis

This comment has been minimized.

Copy link
Member

commented Apr 13, 2016

LGTM here if it's rejected or gets stalled upstream

@jbergstroem

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2016

@bnoordhuis silent upstream -- I'd be keen on getting this in 6.x. There's still time but I'd just like a LGTM from you so I can land it quickly if needed.

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Apr 19, 2016

LGTM then.

@jbergstroem

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2016

Thanks. I will hold off for a week (or whatever's closing in on 6.x) until I merge as-is.

@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 19, 2016

@jbergstroem ... the current plan is to cut the v6 release on Tuesday the 26th.

@jbergstroem

This comment has been minimized.

Copy link
Member Author

commented Apr 20, 2016

@bnoordhuis do we carry this in node-gyp too?

bnoordhuis added a commit to bnoordhuis/node-gyp that referenced this pull request Apr 20, 2016

gyp: inherit CC/CXX for CC/CXX.host
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Refs: nodejs/node#6173
@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Apr 20, 2016

I guess we should for consistency: nodejs/node-gyp#908

@jbergstroem

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2016

Merging this. Was hoping for upstream but hopefully they'll catch up in time.

@jbergstroem jbergstroem force-pushed the jbergstroem:fix/gyp-cxx.host branch Apr 24, 2016

gyp: inherit parent for `*.host`
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: #6173
Fixes: #6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@jbergstroem

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2016

@jbergstroem

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2016

PPC slaves unrelated.

@jbergstroem jbergstroem force-pushed the jbergstroem:fix/gyp-cxx.host branch to f1294f5 Apr 24, 2016

@jbergstroem jbergstroem merged commit f1294f5 into nodejs:master Apr 24, 2016

joelostrowski added a commit to joelostrowski/node that referenced this pull request Apr 25, 2016

gyp: inherit parent for `*.host`
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: nodejs#6173
Fixes: nodejs#6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

jasnell added a commit that referenced this pull request Apr 26, 2016

gyp: inherit parent for `*.host`
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: #6173
Fixes: #6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

bnoordhuis added a commit to bnoordhuis/node-gyp that referenced this pull request Apr 28, 2016

gyp: inherit CC/CXX for CC/CXX.host
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

PR-URL: nodejs#908
Refs: nodejs/node#6173
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@rvagg

This comment has been minimized.

Copy link
Member

commented Jun 2, 2016

I think -1 for LTS, who knows what crazy build environments ppl have out there that this might impact

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Jun 2, 2016

thanks @rvagg labeling as don't land

bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Oct 8, 2016

gyp: inherit parent for `*.host`
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: nodejs#6173
Fixes: nodejs#6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

refack added a commit that referenced this pull request Apr 18, 2017

gyp: inherit parent for `*.host`
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: #6173
Fixes: #6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

refack added a commit to refack/node-gyp that referenced this pull request Apr 23, 2017

gyp: inherit CC/CXX for CC/CXX.host
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

PR-URL: nodejs#908
Refs: nodejs/node#6173
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

evanlucas added a commit that referenced this pull request Apr 25, 2017

gyp: inherit parent for `*.host`
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: #6173
Fixes: #6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

@evanlucas evanlucas referenced this pull request May 1, 2017

Merged

v7.10.0 proposal #12775

evanlucas added a commit that referenced this pull request May 1, 2017

gyp: inherit parent for `*.host`
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: #6173
Fixes: #6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

evanlucas added a commit that referenced this pull request May 2, 2017

gyp: inherit parent for `*.host`
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: #6173
Fixes: #6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

refack added a commit to refack/node that referenced this pull request May 16, 2017

gyp: inherit parent for `*.host`
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: nodejs#6173
Fixes: nodejs#6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

sam-github pushed a commit to sam-github/node that referenced this pull request Jul 12, 2017

gyp: inherit parent for `*.host`
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: nodejs#6173
Fixes: nodejs#6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

sam-github pushed a commit to sam-github/node that referenced this pull request Jul 18, 2017

gyp: inherit parent for `*.host`
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: nodejs#6173
Fixes: nodejs#6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

refack added a commit to refack/node that referenced this pull request Jul 18, 2017

gyp: inherit parent for `*.host`
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: nodejs#6173
Fixes: nodejs#6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

refack added a commit to refack/node that referenced this pull request Aug 9, 2017

gyp: inherit parent for `*.host`
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: nodejs#6173
Fixes: nodejs#6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

refack added a commit to refack/node-gyp that referenced this pull request Aug 19, 2017

gyp: inherit CC/CXX for CC/CXX.host
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

PR-URL: nodejs#908
Refs: nodejs/node#6173
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

refack added a commit to refack/node that referenced this pull request Aug 19, 2017

gyp: inherit parent for `*.host`
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: nodejs#6173
Fixes: nodejs#6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

refack added a commit to refack/node that referenced this pull request Aug 23, 2017

gyp: inherit parent for `*.host`
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: nodejs#6173
Fixes: nodejs#6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

addaleax added a commit to addaleax/ayo that referenced this pull request Aug 25, 2017

gyp: inherit parent for `*.host`
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: nodejs/node#6173
Fixes: nodejs/node#6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

addaleax added a commit to ayojs/ayo that referenced this pull request Aug 28, 2017

gyp: inherit parent for `*.host`
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: nodejs/node#6173
Fixes: nodejs/node#6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins added a commit that referenced this pull request Sep 10, 2017

gyp: inherit parent for `*.host`
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: #6173
Fixes: #6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

@MylesBorins MylesBorins referenced this pull request Sep 10, 2017

Merged

v8.5.0 proposal #15308

MylesBorins added a commit that referenced this pull request Sep 12, 2017

gyp: inherit parent for `*.host`
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: #6173
Fixes: #6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.