New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: correct error message for invalid trailer #6308

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@bengl
Member

bengl commented Apr 20, 2016

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

http

Description of change

Prevent misleading error messages when trailers are invalid.

http: correct error message for invalid trailer
Prevent misleading error messages when trailers are invalid.
@jasnell

This comment has been minimized.

Member

jasnell commented Apr 20, 2016

LGTM

2 similar comments
@addaleax

This comment has been minimized.

Member

addaleax commented Apr 20, 2016

LGTM

@mscdex

This comment has been minimized.

Contributor

mscdex commented Apr 20, 2016

LGTM

@estliberitas estliberitas force-pushed the nodejs:master branch 2 times, most recently to c7066fb Apr 26, 2016

jasnell added a commit that referenced this pull request Apr 27, 2016

http: correct error message for invalid trailer
Prevent misleading error messages when trailers are invalid.

PR-URL: #6308
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
@jasnell

This comment has been minimized.

Member

jasnell commented Apr 27, 2016

Landed in 31bef6b

@jasnell jasnell closed this Apr 27, 2016

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment