Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: don't assume IPv6 in test-regress-GH-5727 #6319

Merged
merged 1 commit into from Apr 21, 2016

Conversation

Projects
None yet
9 participants
@cjihrig
Copy link
Contributor

commented Apr 21, 2016

Checklist
  • tests and code linting passes
Affected core subsystem(s)

test

Description of change

test/parallel/test-regress-GH-5727 assumed that one of the servers would be listening on IPv6. This breaks when the machine running the test doesn't have IPv6. This commit builds the connection key that is compared dynamically.

Refs #5732

R= @Trott

@Trott

This comment has been minimized.

Copy link
Member

commented Apr 21, 2016

LGTM but I'm not really sure what _connectionKey is all about, so /cc @indutny @trevnorris just in case there's a subtlety I'm missing...

@Trott

This comment has been minimized.

Copy link
Member

commented Apr 21, 2016

/cc @dirceu

@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 21, 2016

LGTM

@dirceu

This comment has been minimized.

Copy link
Contributor

commented Apr 21, 2016

Sorry, I didn't think about this possibility. Good catch. 👍

@Trott

This comment has been minimized.

Copy link
Member

commented Apr 21, 2016

I wonder what happened that caused this to suddenly pop up as of just a few hours ago. (Change to the setup/config of the devices in CI? Change in the code base?)

Anyway, looks like it's failing 100% of the time, and the change seems small and easy to undo, so I'd be all for an expedited landing.

/cc @nodejs/build @nodejs/testing

@santigimeno

This comment has been minimized.

Copy link
Member

commented Apr 21, 2016

LGTM

@jbergstroem

This comment has been minimized.

Copy link
Member

commented Apr 21, 2016

No changes in CI afaik.

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2016

@Trott I'm guessing it only started showing up last night because that's when the PR adding the test landed. Apparently, the test failed on the CI run in which it was added (see #5732), but still got landed.

CI for this PR: https://ci.nodejs.org/job/node-test-pull-request/2356/

@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 21, 2016

My fault on that one, I'm guessing that I didn't look closely enough at the results and assumed that it was one of the known flaky tests.

@indutny

This comment has been minimized.

Copy link
Member

commented Apr 21, 2016

LGTM

test: don't assume IPv6 in test-regress-GH-5727
test/parallel/test-regress-GH-5727 assumed that one of the
servers would be listening on IPv6. This breaks when the machine
running the test doesn't have IPv6. This commit builds the
connection key that is compared dynamically.

Refs: #5732
PR-URL: #6319
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>

@cjihrig cjihrig force-pushed the cjihrig:test branch to 1e4d053 Apr 21, 2016

@cjihrig cjihrig merged commit 1e4d053 into nodejs:master Apr 21, 2016

@cjihrig cjihrig deleted the cjihrig:test branch Apr 21, 2016

joelostrowski added a commit to joelostrowski/node that referenced this pull request Apr 25, 2016

test: don't assume IPv6 in test-regress-nodejsGH-5727
test/parallel/test-regress-GH-5727 assumed that one of the
servers would be listening on IPv6. This breaks when the machine
running the test doesn't have IPv6. This commit builds the
connection key that is compared dynamically.

Refs: nodejs#5732
PR-URL: nodejs#6319
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>

jasnell added a commit that referenced this pull request Apr 26, 2016

test: don't assume IPv6 in test-regress-GH-5727
test/parallel/test-regress-GH-5727 assumed that one of the
servers would be listening on IPv6. This breaks when the machine
running the test doesn't have IPv6. This commit builds the
connection key that is compared dynamically.

Refs: #5732
PR-URL: #6319
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
@MylesBorins

This comment has been minimized.

Copy link
Member

commented Jun 1, 2016

adding dont-land as this file does not exist in v4... please feel free to update

@refack refack referenced this pull request Oct 18, 2018

Merged

build: spawn `make test-ci` with `-j1` #23733

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.