Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade to V8 5.0.71.34 #6320

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@ofrobots
Copy link
Contributor

commented Apr 21, 2016

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Pick up the latest bug fix from the V8 5.0 branch.

Original commit message:
V8-Commit: v8/v8@c36773f

Version 5.0.71.34 (cherry-pick)
Merged 9acbca1

[es6] Fix bug in pattern re-writing

BUG=v8:4891
LOG=N
R=littledan@chromium.org

Review URL: https://codereview.chromium.org/1906633002 .

R=@nodejs/v8
/cc @jasnell
CI: https://ci.nodejs.org/job/node-test-pull-request/2350/

deps: upgrade to V8 5.0.71.34
Pick up the latest bug fix from the V8 5.0 branch.

Original commit message:
V8-Commit: v8/v8@c36773f
  Version 5.0.71.34 (cherry-pick)
  Merged 9acbca1

  [es6] Fix bug in pattern re-writing

  BUG=v8:4891
  LOG=N
  R=littledan@chromium.org

  Review URL: https://codereview.chromium.org/1906633002 .

@ofrobots ofrobots referenced this pull request Apr 21, 2016

Closed

Planning for v6 #5766

@mscdex mscdex added the V8 Engine label Apr 21, 2016

@mscdex mscdex added this to the 6.0.0 milestone Apr 21, 2016

@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Apr 21, 2016

LGTM pending CI

@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 21, 2016

LGTM

1 similar comment
@targos

This comment has been minimized.

Copy link
Member

commented Apr 21, 2016

LGTM

@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 21, 2016

@ofrobots ... want to go ahead and get this landed today? I might take some time this afternoon to put together a v6 RC.4

@ofrobots

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2016

test-regress-GH-5727 on ARM seems to be a machine/network related issue. I will go ahead and land this.

@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Apr 21, 2016

@ofrobots that test has been fixed since the time you started your CI run, so it's safe to ignore.

@ofrobots

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2016

Thanks. Landed as 49e42c5.

@ofrobots ofrobots closed this Apr 21, 2016

ofrobots added a commit that referenced this pull request Apr 21, 2016

deps: upgrade to V8 5.0.71.34
Pick up the latest bug fix from the V8 5.0 branch.

Original commit message:
V8-Commit: v8/v8@c36773f
  Version 5.0.71.34 (cherry-pick)
  Merged 9acbca1

  [es6] Fix bug in pattern re-writing

  BUG=v8:4891
  LOG=N
  R=littledan@chromium.org

  Review URL: https://codereview.chromium.org/1906633002 .

PR-URL: #6320
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>

@ofrobots ofrobots deleted the ofrobots:5.0.71.34 branch Apr 21, 2016

joelostrowski added a commit to joelostrowski/node that referenced this pull request Apr 25, 2016

deps: upgrade to V8 5.0.71.34
Pick up the latest bug fix from the V8 5.0 branch.

Original commit message:
V8-Commit: v8/v8@c36773f
  Version 5.0.71.34 (cherry-pick)
  Merged 9acbca1

  [es6] Fix bug in pattern re-writing

  BUG=v8:4891
  LOG=N
  R=littledan@chromium.org

  Review URL: https://codereview.chromium.org/1906633002 .

PR-URL: nodejs#6320
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>

jasnell added a commit that referenced this pull request Apr 26, 2016

deps: upgrade to V8 5.0.71.34
Pick up the latest bug fix from the V8 5.0 branch.

Original commit message:
V8-Commit: v8/v8@c36773f
  Version 5.0.71.34 (cherry-pick)
  Merged 9acbca1

  [es6] Fix bug in pattern re-writing

  BUG=v8:4891
  LOG=N
  R=littledan@chromium.org

  Review URL: https://codereview.chromium.org/1906633002 .

PR-URL: #6320
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.