Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase the platform timeout for AIX #6342

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@mhdawson
Copy link
Member

commented Apr 21, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

There have been failures on AIX due to the slower
default loopback performance. So far I've resisted
updating the global timeout but seeing another
new failure in a newly added test I now think the
right thing is to just extending the platform
timeout for AIX. This commit does that.

addresses: #6333

test: increase the platform timeout for AIX
There have been failures on AIX due to the slower
default loopback performance. So far I've resisted
updating the global timeout but seeing another
new failure in a newly added test I now think the
right thing is to just extending the platform
timeout for AIX. This commit does that.
@mhdawson

This comment has been minimized.

Copy link
Member Author

commented Apr 21, 2016

@mhdawson mhdawson self-assigned this Apr 21, 2016

@mhdawson

This comment has been minimized.

Copy link
Member Author

commented Apr 21, 2016

CI run all green

@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 21, 2016

LGTM

@Fishrock123

This comment has been minimized.

Copy link
Member

commented Apr 24, 2016

LGTM

mhdawson added a commit that referenced this pull request Apr 25, 2016

test: increase the platform timeout for AIX
There have been failures on AIX due to the slower
default loopback performance. So far I've resisted
updating the global timeout but seeing another
new failure in a newly added test I now think the
right thing is to just extend the platform
timeout for AIX. This commit does that.

PR-URL: #6342
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@mhdawson

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2016

Landed as 75e073f

@mhdawson

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2016

Only needs a backport if #6286 is backported

joelostrowski added a commit to joelostrowski/node that referenced this pull request Apr 25, 2016

test: increase the platform timeout for AIX
There have been failures on AIX due to the slower
default loopback performance. So far I've resisted
updating the global timeout but seeing another
new failure in a newly added test I now think the
right thing is to just extend the platform
timeout for AIX. This commit does that.

PR-URL: nodejs#6342
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

jasnell added a commit that referenced this pull request Apr 26, 2016

test: increase the platform timeout for AIX
There have been failures on AIX due to the slower
default loopback performance. So far I've resisted
updating the global timeout but seeing another
new failure in a newly added test I now think the
right thing is to just extend the platform
timeout for AIX. This commit does that.

PR-URL: #6342
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins added a commit that referenced this pull request May 18, 2016

test: increase the platform timeout for AIX
There have been failures on AIX due to the slower
default loopback performance. So far I've resisted
updating the global timeout but seeing another
new failure in a newly added test I now think the
right thing is to just extend the platform
timeout for AIX. This commit does that.

PR-URL: #6342
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins added a commit that referenced this pull request May 18, 2016

test: increase the platform timeout for AIX
There have been failures on AIX due to the slower
default loopback performance. So far I've resisted
updating the global timeout but seeing another
new failure in a newly added test I now think the
right thing is to just extend the platform
timeout for AIX. This commit does that.

PR-URL: #6342
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

@MylesBorins MylesBorins referenced this pull request May 18, 2016

Merged

v4.4.5 proposal #6824

@mhdawson mhdawson deleted the mhdawson:aixtime branch Mar 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.