Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix broken references #6350

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@gromnitsky
Copy link
Contributor

commented Apr 22, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Fix some cross-references.

@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 22, 2016

LGTM

2 similar comments
@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2016

LGTM

@JungMinu

This comment has been minimized.

Copy link
Member

commented Apr 23, 2016

LGTM

jasnell added a commit that referenced this pull request Apr 23, 2016

doc: fix broken references
PR-URL: #6350
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 23, 2016

Landed in 983a809

@jasnell jasnell closed this Apr 23, 2016

@gromnitsky gromnitsky deleted the gromnitsky:doc-ref-fix-again branch Apr 24, 2016

joelostrowski added a commit to joelostrowski/node that referenced this pull request Apr 25, 2016

doc: fix broken references
PR-URL: nodejs#6350
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>

jasnell added a commit that referenced this pull request Apr 26, 2016

doc: fix broken references
PR-URL: #6350
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
@MylesBorins

This comment has been minimized.

Copy link
Member

commented Jun 1, 2016

This does not land cleanly, I am adding the dont-land label for LTS. Please feel free to open a backport PR directly to v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.