Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: squelch -Wunused-variable in non-icu builds #6351

Merged
merged 1 commit into from Apr 22, 2016

Conversation

Projects
None yet
5 participants
@bnoordhuis
Copy link
Member

commented Apr 22, 2016

@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 22, 2016

LGTM. Good catch. Thank you

@addaleax

This comment has been minimized.

Copy link
Member

commented Apr 22, 2016

LGTM

src: squelch -Wunused-variable in non-icu builds
Silence the following compiler warning when building without ICU:

    ../src/node_config.cc:32:16: warning: unused variable 'env'
    [-Wunused-variable]
       Environment* env = Environment::GetCurrent(context);

PR-URL: #6351
Reviewed-By: James M Snell <jasnell@gmail.com>

@bnoordhuis bnoordhuis force-pushed the bnoordhuis:squelch-warning branch to 5eb4ec0 Apr 22, 2016

@bnoordhuis bnoordhuis closed this Apr 22, 2016

@bnoordhuis bnoordhuis deleted the bnoordhuis:squelch-warning branch Apr 22, 2016

@bnoordhuis bnoordhuis merged commit 5eb4ec0 into nodejs:master Apr 22, 2016

@bnoordhuis

This comment has been minimized.

Copy link
Member Author

commented Apr 22, 2016

Sorry @addaleax, missed your comment.

@addaleax

This comment has been minimized.

Copy link
Member

commented Apr 22, 2016

@bnoordhuis nevermind :)

joelostrowski added a commit to joelostrowski/node that referenced this pull request Apr 25, 2016

src: squelch -Wunused-variable in non-icu builds
Silence the following compiler warning when building without ICU:

    ../src/node_config.cc:32:16: warning: unused variable 'env'
    [-Wunused-variable]
       Environment* env = Environment::GetCurrent(context);

PR-URL: nodejs#6351
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell added a commit that referenced this pull request Apr 26, 2016

src: squelch -Wunused-variable in non-icu builds
Silence the following compiler warning when building without ICU:

    ../src/node_config.cc:32:16: warning: unused variable 'env'
    [-Wunused-variable]
       Environment* env = Environment::GetCurrent(context);

PR-URL: #6351
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins

This comment has been minimized.

Copy link
Member

commented Jun 1, 2016

Marking as don't land for now... please update if I am incorrect and it should be backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.