Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

querystring: fix comments #6365

Merged
merged 1 commit into from Apr 25, 2016

Conversation

Projects
None yet
5 participants
@mscdex
Copy link
Contributor

commented Apr 25, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)
  • querystring
Description of change

Fixes a couple of comments.

@mscdex mscdex added the querystring label Apr 25, 2016

@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2016

LGTM

2 similar comments
@targos

This comment has been minimized.

Copy link
Member

commented Apr 25, 2016

LGTM

@evanlucas

This comment has been minimized.

Copy link
Member

commented Apr 25, 2016

LGTM

querystring: fix comments
PR-URL: #6365
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

@mscdex mscdex force-pushed the mscdex:querystring-fix-comments branch 2 times, most recently to d5922bd Apr 25, 2016

@mscdex mscdex merged commit d5922bd into nodejs:master Apr 25, 2016

@mscdex mscdex deleted the mscdex:querystring-fix-comments branch Apr 25, 2016

joelostrowski added a commit to joelostrowski/node that referenced this pull request Apr 25, 2016

querystring: fix comments
PR-URL: nodejs#6365
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

jasnell added a commit that referenced this pull request Apr 26, 2016

querystring: fix comments
PR-URL: #6365
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@MylesBorins

This comment has been minimized.

Copy link
Member

commented Jun 1, 2016

setting as don't land for right now

@mscdex let me know if this was incorrect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.