Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add estliberitas to collaborators #6386

Closed

Conversation

Projects
None yet
5 participants
@estliberitas
Copy link
Contributor

commented Apr 26, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Adding myself (estliberitas)

@jbergstroem

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

Great to have you on board! LGTM

@Trott

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

LGTM. Welcome!

@estliberitas

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2016

Ok, gonna follow all the process and land it, I guess.

@jbergstroem

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

Feel free to force push the amended commit to the same branch if you're unsure about the final commit message; me or someone else'll have a look at it.

@jbergstroem

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

Well, you should do that regardless, but you get the point :)

estliberitas added a commit that referenced this pull request Apr 26, 2016

doc: add estliberitas to collaborators
PR-URL: #6386
Reviewed-By: Johan Bergström <bugs@bergstroem.nu
Reviewed-By: Evan Lucas <evanlucas@me.com>
@estliberitas

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2016

Landed as d90c42d

@evanlucas

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

Welcome aboard

@jbergstroem

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

@estliberitas you forgot a closing anchor on my email: Johan Bergström <bugs@bergstroem.nu -- if no one else has merged their commits you have a few minutes to force push to master. Let me know if you're uncomfortable doing so.

@jbergstroem

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

..and now a missing n :)

@jbergstroem

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

..and now a period?

estliberitas added a commit that referenced this pull request Apr 26, 2016

doc: add estliberitas to collaborators
PR-URL: #6386
Reviewed-By: Johan Bergström <bugs@bergstroemnu>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@estliberitas

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2016

@jbergstroem Don't get it.

@estliberitas

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2016

I fixed it with git commit --amend then somehow one symbol is always cut

@jbergstroem

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

@estliberitas never mind; someone pushed a commit on top of yours anyway. Could perhaps be your EDITOR not handling ö correctly?

@jbergstroem

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

@estliberitas moving forward, perhaps set and test LC_/locale stuff?

@estliberitas

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2016

@jbergstroem yep, doing that

@jbergstroem

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

@estliberitas great! again: happy to see you join :)

@estliberitas

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2016

@jbergstroem thanks!

@estliberitas

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2016

@jbergstroem ah, LC_* was not set at all. Now it's fixed and no more such problems. 😉

jasnell added a commit that referenced this pull request Apr 26, 2016

doc: add estliberitas to collaborators
PR-URL: #6386
Reviewed-By: Johan Bergström <bugs@bergstroemnu>
Reviewed-By: Evan Lucas <evanlucas@me.com>

MylesBorins added a commit that referenced this pull request Jun 1, 2016

doc: add estliberitas to collaborators
PR-URL: #6386
Reviewed-By: Johan Bergström <bugs@bergstroem.nu
Reviewed-By: Evan Lucas <evanlucas@me.com>

@MylesBorins MylesBorins referenced this pull request Jun 24, 2016

Merged

v4.4.7 proposal #7395

MylesBorins added a commit that referenced this pull request Jun 24, 2016

doc: add estliberitas to collaborators
PR-URL: #6386
Reviewed-By: Johan Bergström <bugs@bergstroem.nu
Reviewed-By: Evan Lucas <evanlucas@me.com>

MylesBorins added a commit that referenced this pull request Jun 24, 2016

doc: add estliberitas to collaborators
PR-URL: #6386
Reviewed-By: Johan Bergström <bugs@bergstroem.nu
Reviewed-By: Evan Lucas <evanlucas@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.