Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add Minqi Pan to collaborators #6387

Closed
wants to merge 1 commit into from

Conversation

@pmq20
Copy link
Contributor

pmq20 commented Apr 26, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Add myself as a collaborator. Hooray!

@jbergstroem

This comment has been minimized.

Copy link
Member

jbergstroem commented Apr 26, 2016

Happy to see you join! LGTM.

Is there a reason you usually abbreviate your name?

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Apr 26, 2016

LGTM. Welcome!

@jbergstroem

This comment has been minimized.

Copy link
Member

jbergstroem commented Apr 26, 2016

Btw, although the PR template is borderline unnecessary here; it would be good to have it in place on all PR's. Eating our down dogfood, etc.

@evanlucas

This comment has been minimized.

Copy link
Member

evanlucas commented Apr 26, 2016

LGTM. Welcome aboard

@estliberitas estliberitas force-pushed the nodejs:master branch Apr 26, 2016
@pmq20

This comment has been minimized.

Copy link
Contributor Author

pmq20 commented Apr 26, 2016

@jbergstroem Thanks. It's a hacker name that I use online. Is it necessary to use real name? If so I could change to Minqi Pan.

@estliberitas estliberitas force-pushed the nodejs:master branch to c7066fb Apr 26, 2016
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Apr 26, 2016

@pmq20 I believe we generally allow aliases if it's what the person wants to be known as, so I think P.S.V.R. is fine. Just know that if your name appears in any documents about new releases or whatever, that's the name that will be used.

@pmq20

This comment has been minimized.

Copy link
Contributor Author

pmq20 commented Apr 26, 2016

@jbergstroem Thanks for pointing it out. I've changed to use the PR template.

@pmq20

This comment has been minimized.

Copy link
Contributor Author

pmq20 commented Apr 26, 2016

@Trott Got it. Thanks for letting me know.

@ChALkeR

This comment has been minimized.

Copy link
Member

ChALkeR commented Apr 26, 2016

LGTM

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Apr 26, 2016

(Although now I see that there are no other aliases in the list and I'm starting to doubt myself. So, if someone else comes along and says otherwise, they probably know something I don't.)

@jbergstroem

This comment has been minimized.

Copy link
Member

jbergstroem commented Apr 26, 2016

@Trott: I don't think we have rules in place, but I would encourage 'real' names unless theres a reason not to use them.

@pmq20 pmq20 force-pushed the pmq20:master branch Apr 26, 2016
@pmq20 pmq20 changed the title doc: add P.S.V.R to collaborators doc: add collaborator P.S.V.R and replace aliases Apr 26, 2016
@pmq20

This comment has been minimized.

Copy link
Contributor Author

pmq20 commented Apr 26, 2016

@jbergstroem @Trott In that spirit I have replaced the old aliases, which introduced more changes. Please have a look and I'll merge them if it looks good to you. Thanks

@pmq20 pmq20 changed the title doc: add collaborator P.S.V.R and replace aliases doc: add collaborator Minqi Pan and replace aliases Apr 26, 2016
@pmq20 pmq20 changed the title doc: add collaborator Minqi Pan and replace aliases doc: add P.S.V.R to collaborators Apr 26, 2016
@pmq20 pmq20 force-pushed the pmq20:master branch Apr 26, 2016
@pmq20

This comment has been minimized.

Copy link
Contributor Author

pmq20 commented Apr 26, 2016

@jbergstroem @Trott I just realised that this was impossible, since old commits all have P.S.V.R inside. Changing them would alter their SHA-1 values which we definitely dislike. I reverted and will merge the original PR. Thanks for your advice though.

@jbergstroem

This comment has been minimized.

Copy link
Member

jbergstroem commented Apr 26, 2016

@pmq20 yeah, we cant really go back at this point but if you're changing the sooner the better I guess.

@pmq20 pmq20 changed the title doc: add P.S.V.R to collaborators doc: add Minqi Pan to collaborators Apr 26, 2016
@pmq20 pmq20 force-pushed the pmq20:master branch Apr 26, 2016
@pmq20

This comment has been minimized.

Copy link
Contributor Author

pmq20 commented Apr 26, 2016

@pmq20 pmq20 force-pushed the pmq20:master branch to a1a8f97 Apr 26, 2016
pmq20 added a commit that referenced this pull request Apr 26, 2016
Also changed alias P.S.V.R to Minqi Pan.

Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
PR-URL: #6387
@pmq20

This comment has been minimized.

Copy link
Contributor Author

pmq20 commented Apr 26, 2016

Landed in 879aeb5

@pmq20 pmq20 closed this Apr 26, 2016
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Apr 26, 2016

@rvagg @jasnell Can you weigh in on weigh in on whether it's OK to alter the CHANGELOG retroactively this way? Does it matter that the name on the commits doesn't match the name in the CHANGELOG now?

@jasnell

This comment has been minimized.

Copy link
Member

jasnell commented Apr 26, 2016

This should be fine.

@Fishrock123

This comment has been minimized.

Copy link
Member

Fishrock123 commented Apr 26, 2016

Retroactively fixing the changelog is fine, yes.

jasnell added a commit that referenced this pull request Apr 26, 2016
Also changed alias P.S.V.R to Minqi Pan.

Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
PR-URL: #6387
MylesBorins added a commit that referenced this pull request Jun 1, 2016
Also changed alias P.S.V.R to Minqi Pan.

Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
PR-URL: #6387
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
MylesBorins added a commit that referenced this pull request Jun 24, 2016
Also changed alias P.S.V.R to Minqi Pan.

Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
PR-URL: #6387
MylesBorins added a commit that referenced this pull request Jun 24, 2016
Also changed alias P.S.V.R to Minqi Pan.

Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
PR-URL: #6387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.