Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add JacksonTian to collaborators #6388

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@JacksonTian
Copy link
Contributor

commented Apr 26, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Added myself as a collaborator following the onboarding process.

@jbergstroem

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

LGTM - great to have you on board!

@Trott

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

LGTM. Welcome! Might be a good idea to make the commit message meaningful rather than just "Hi!" just to set a good example for others contributing to the project.

@JacksonTian

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2016

thanks @Trott .

doc: add JacksonTian to collaborators
Added myself as a collaborator following the onboarding process.

@JacksonTian JacksonTian force-pushed the JacksonTian:collaborator branch to aa19077 Apr 26, 2016

@evanlucas

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

LGTM. Welcome aboard

@JacksonTian JacksonTian added the doc label Apr 26, 2016

@estliberitas estliberitas force-pushed the nodejs:master branch 2 times, most recently to c7066fb Apr 26, 2016

@ChALkeR

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

LGTM

JacksonTian added a commit that referenced this pull request Apr 26, 2016

doc: add JacksonTian to collaborators
Added myself as a collaborator following the onboarding process.

PR-URL: #6388
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@JacksonTian

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2016

landed in bf3ffc2

JacksonTian added a commit that referenced this pull request Apr 26, 2016

doc: add JacksonTian to collaborators
Added myself as a collaborator following the onboarding process.

PR-URL: #6388
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

jasnell added a commit that referenced this pull request Apr 26, 2016

doc: add JacksonTian to collaborators
Added myself as a collaborator following the onboarding process.

PR-URL: #6388
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

MylesBorins added a commit that referenced this pull request Jun 1, 2016

doc: add JacksonTian to collaborators
Added myself as a collaborator following the onboarding process.

PR-URL: #6388
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

@MylesBorins MylesBorins referenced this pull request Jun 24, 2016

Merged

v4.4.7 proposal #7395

MylesBorins added a commit that referenced this pull request Jun 24, 2016

doc: add JacksonTian to collaborators
Added myself as a collaborator following the onboarding process.

PR-URL: #6388
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

MylesBorins added a commit that referenced this pull request Jun 24, 2016

doc: add JacksonTian to collaborators
Added myself as a collaborator following the onboarding process.

PR-URL: #6388
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

@ChALkeR ChALkeR referenced this pull request Oct 7, 2016

Closed

doc: fix typo in email address in README #8941

2 of 2 tasks complete

@JacksonTian JacksonTian deleted the JacksonTian:collaborator branch May 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.