Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add eljefedelrodeodeljefe to collaborators #6389

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@eljefedelrodeodeljefe
Copy link
Contributor

commented Apr 26, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

adds me to the readme.md as collaborator

@ChALkeR

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

LGTM, welcome!

@ChALkeR ChALkeR added the doc label Apr 26, 2016

@evanlucas

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

LGTM. Welcome aboard

@santigimeno

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

LGTM and welcome!

@eljefedelrodeodeljefe

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/2395/

Gonna merge this after CI :) Thanks guys

eljefedelrodeodeljefe added a commit that referenced this pull request Apr 26, 2016

doc: add eljefedelrodeodeljefe to collaborators
PR-URL: #6389
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@eljefedelrodeodeljefe

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2016

Landed in be5d699

@eljefedelrodeodeljefe eljefedelrodeodeljefe deleted the eljefedelrodeodeljefe:doc/add-eljefedelrodeodeljefe-to-collaborators branch Apr 26, 2016

@eljefedelrodeodeljefe

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2016

With the process in the collaborators guide the PRs won't be marked as merged on GitHub right? Guess it doesn't matter too much.

@Trott

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

@eljefedelrodeodeljefe That's right. @evanlucas told me and others how to make it so that it shows as merged but I don't remember what it was.

@ChALkeR

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

@eljefedelrodeodeljefe @Trott
Trivial — just make sure your branch is rebased on master and push the final commits with all the modifications (including the PR-URL, Reviewed-By, etc) to your branch before landing it to master.

GitHub will label the PR as merged when it sees that all the commits with identical ids are landed on the target branch.

@eljefedelrodeodeljefe

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2016

Will try that next time then. Thought I did all that. Thanks

@jbergstroem

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

@ChALkeR we should really add that to the collaborators guide -- it makes it easier to make the assumption that the last commit(s) in the PR was also the one's merged.

@jbergstroem

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

@eljefedelrodeodeljefe you have to force push to your branch since you're rewriting history (git push -f)

@ChALkeR

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

@eljefedelrodeodeljefe The branch had 3f3f41a, the merged commit was be5d699. Those were not identical =).

Update: sorry, copy-pasted wrong commit id. Fixed.

@eljefedelrodeodeljefe

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2016

Yep, after @jbergstroem comments I was realizing that. After adding metadata it needs another force push to the fork.

jasnell added a commit that referenced this pull request Apr 26, 2016

doc: add eljefedelrodeodeljefe to collaborators
PR-URL: #6389
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

eljefedelrodeodeljefe added a commit that referenced this pull request May 19, 2016

doc: fix name to match git log
Git logs print my full name Robert Jefe Lindstaedt.
When I did #6389 I forgot simply forgot it.

PR-URL: #6880
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Fishrock123 added a commit that referenced this pull request May 23, 2016

doc: fix name to match git log
Git logs print my full name Robert Jefe Lindstaedt.
When I did #6389 I forgot simply forgot it.

PR-URL: #6880
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins added a commit that referenced this pull request Jun 1, 2016

doc: add eljefedelrodeodeljefe to collaborators
PR-URL: #6389
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

rvagg added a commit that referenced this pull request Jun 2, 2016

doc: fix name to match git log
Git logs print my full name Robert Jefe Lindstaedt.
When I did #6389 I forgot simply forgot it.

PR-URL: #6880
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins added a commit that referenced this pull request Jun 3, 2016

doc: fix name to match git log
Git logs print my full name Robert Jefe Lindstaedt.
When I did #6389 I forgot simply forgot it.

PR-URL: #6880
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

@MylesBorins MylesBorins referenced this pull request Jun 24, 2016

Merged

v4.4.7 proposal #7395

MylesBorins added a commit that referenced this pull request Jun 24, 2016

doc: add eljefedelrodeodeljefe to collaborators
PR-URL: #6389
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

MylesBorins added a commit that referenced this pull request Jun 24, 2016

doc: fix name to match git log
Git logs print my full name Robert Jefe Lindstaedt.
When I did #6389 I forgot simply forgot it.

PR-URL: #6880
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins added a commit that referenced this pull request Jun 24, 2016

doc: add eljefedelrodeodeljefe to collaborators
PR-URL: #6389
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

MylesBorins added a commit that referenced this pull request Jun 24, 2016

doc: fix name to match git log
Git logs print my full name Robert Jefe Lindstaedt.
When I did #6389 I forgot simply forgot it.

PR-URL: #6880
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.