New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: ensures consistent grammar in node.1 file #6426

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@justshiv
Contributor

justshiv commented Apr 27, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Grammar in node.1 file was inconsistent when starting man-page responses (Open vs Opens). I've changed this to ensure these responses are consistent throughout.

@Trott Trott added the doc label Apr 27, 2016

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott
Member

Trott commented Apr 27, 2016

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Apr 27, 2016

Member

LGTM

Member

Trott commented Apr 27, 2016

LGTM

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott
Member

Trott commented Apr 27, 2016

@thefourtheye

This comment has been minimized.

Show comment
Hide comment
@thefourtheye

thefourtheye Apr 27, 2016

Contributor

LGTM

Contributor

thefourtheye commented Apr 27, 2016

LGTM

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Apr 27, 2016

Member

Only CI failure is a currently-problematic test on OS X, so CI is good.

Member

Trott commented Apr 27, 2016

Only CI failure is a currently-problematic test on OS X, so CI is good.

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Apr 27, 2016

Member

Should the commit message say ensure instead of ensures? Seems like an unnecessary nit to me, but maybe someone else thinks differently?

Member

Trott commented Apr 27, 2016

Should the commit message say ensure instead of ensures? Seems like an unnecessary nit to me, but maybe someone else thinks differently?

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Apr 27, 2016

Member

LGTM. Commit would be better as ensure, but we can fix that when landing.

Member

Fishrock123 commented Apr 27, 2016

LGTM. Commit would be better as ensure, but we can fix that when landing.

@justshiv

This comment has been minimized.

Show comment
Hide comment
@justshiv

justshiv Apr 28, 2016

Contributor

Ah sorry, the convention in my org is to use third person present verbs 😄

Contributor

justshiv commented Apr 28, 2016

Ah sorry, the convention in my org is to use third person present verbs 😄

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Apr 29, 2016

Member

@justshiv Btw, git thinks your name is justshiv

If you're ok with that, I'll land this as-is.

But if you'd like you can set your name to git by doing:

$ git config --global user.name "whatever you want to be known as"

and then git commit --amend --reset-author

Member

Fishrock123 commented Apr 29, 2016

@justshiv Btw, git thinks your name is justshiv

If you're ok with that, I'll land this as-is.

But if you'd like you can set your name to git by doing:

$ git config --global user.name "whatever you want to be known as"

and then git commit --amend --reset-author

Fishrock123 added a commit to Fishrock123/node that referenced this pull request May 2, 2016

doc: ensure consistent grammar in node.1 file
PR-URL: nodejs#6426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 May 2, 2016

Member

Thanks, landed in 8ebec08

We can always .mailmap your name later. :)

Member

Fishrock123 commented May 2, 2016

Thanks, landed in 8ebec08

We can always .mailmap your name later. :)

@Fishrock123 Fishrock123 closed this May 2, 2016

Fishrock123 added a commit that referenced this pull request May 4, 2016

doc: ensure consistent grammar in node.1 file
PR-URL: #6426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

joelostrowski added a commit to joelostrowski/node that referenced this pull request May 4, 2016

doc: ensure consistent grammar in node.1 file
PR-URL: nodejs#6426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins added a commit that referenced this pull request Jun 2, 2016

doc: ensure consistent grammar in node.1 file
PR-URL: #6426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Jun 2, 2016

Member

oh hey @justshiv !!! so happy to see you got something into core

Member

MylesBorins commented Jun 2, 2016

oh hey @justshiv !!! so happy to see you got something into core

@MylesBorins MylesBorins referenced this pull request Jun 24, 2016

Merged

v4.4.7 proposal #7395

MylesBorins added a commit that referenced this pull request Jun 24, 2016

doc: ensure consistent grammar in node.1 file
PR-URL: #6426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins added a commit that referenced this pull request Jun 24, 2016

doc: ensure consistent grammar in node.1 file
PR-URL: #6426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment