New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix incorrect syntax in examples #6463

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@evanlucas
Member

evanlucas commented Apr 29, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

The cluster docs had a period instead of a semicolon at the end of two
lines.

@evanlucas evanlucas added the doc label Apr 29, 2016

@jasnell

View changes

Show outdated Hide outdated doc/api/cluster.md
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Apr 29, 2016

Member

LGTM with a nit

Member

jasnell commented Apr 29, 2016

LGTM with a nit

doc: fix incorrect syntax in examples
The cluster docs had a period instead of a semicolon at the end of two
lines.

@mscdex mscdex added the cluster label Apr 29, 2016

@mscdex

This comment has been minimized.

Show comment
Hide comment
@mscdex

mscdex Apr 29, 2016

Contributor

LGTM

Contributor

mscdex commented Apr 29, 2016

LGTM

@JacksonTian

This comment has been minimized.

Show comment
Hide comment
@JacksonTian

JacksonTian Apr 29, 2016

Contributor

LGTM

Contributor

JacksonTian commented Apr 29, 2016

LGTM

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Apr 29, 2016

Contributor

LGTM

Contributor

cjihrig commented Apr 29, 2016

LGTM

jasnell added a commit that referenced this pull request Apr 30, 2016

doc: fix incorrect syntax in examples
The cluster docs had a period instead of a semicolon at the end of two
lines.

PR-URL: #6463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Jackson Tian <shvyo1987@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Apr 30, 2016

Member

Landed in 4b0dda0

Member

jasnell commented Apr 30, 2016

Landed in 4b0dda0

@jasnell jasnell closed this Apr 30, 2016

Fishrock123 added a commit that referenced this pull request May 4, 2016

doc: fix incorrect syntax in examples
The cluster docs had a period instead of a semicolon at the end of two
lines.

PR-URL: #6463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Jackson Tian <shvyo1987@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

joelostrowski added a commit to joelostrowski/node that referenced this pull request May 4, 2016

doc: fix incorrect syntax in examples
The cluster docs had a period instead of a semicolon at the end of two
lines.

PR-URL: nodejs#6463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Jackson Tian <shvyo1987@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment