New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: deprecate `tmpDir()` in favour of `tmpdir()` #6739

Merged
merged 1 commit into from Jun 30, 2016

Conversation

Projects
None yet
7 participants
@Fishrock123
Member

Fishrock123 commented May 13, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

os

Description of change

tmpdir() was introduced as replacement 3 years ago in
3fe6aba

cc @bnoordhuis?

CI: https://ci.nodejs.org/job/node-test-pull-request/2636/

@Fishrock123

This comment has been minimized.

Member

Fishrock123 commented May 13, 2016

@cjihrig

This comment has been minimized.

Contributor

cjihrig commented May 13, 2016

LGTM

@Fishrock123

This comment has been minimized.

Member

Fishrock123 commented May 13, 2016

@ChALkeR could you npm-check this?

@ChALkeR

This comment has been minimized.

Member

ChALkeR commented May 13, 2016

@Fishrock123 https://gist.github.com/ChALkeR/0140f2757f33c06121e2002acc4b87b9

I searched for .tmpDir(, and lines with io.tmpDir look like a false positives.

@jasnell

This comment has been minimized.

Member

jasnell commented May 13, 2016

LGTM if a citgm check comes up good.

@MylesBorins

This comment has been minimized.

@ChALkeR

This comment has been minimized.

Member

ChALkeR commented May 14, 2016

@Fishrock123 Also note that a significant part of those are using something like os.tmpdir ? os.tmpdir() : os.tmpDir(), those are also fine.

@Fishrock123

This comment has been minimized.

Member

Fishrock123 commented Jun 29, 2016

@jasnell

This comment has been minimized.

Member

jasnell commented Jun 29, 2016

one failure in citgm, looks like an unrelated jquery failure on osx. this LGTM

@MylesBorins

This comment has been minimized.

Member

MylesBorins commented Jun 29, 2016

jquery is a known flaky... I'm going to report it to them and add it to the flaky list

os: deprecate `tmpDir()` in favour of `tmpdir()`
`tmpdir()` was introduced as replacement 3 years ago in
3fe6aba

PR-URL: #6739
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@Fishrock123 Fishrock123 force-pushed the Fishrock123:os-deprecate-tmpDir branch to 5e5ec2c Jun 30, 2016

@Fishrock123 Fishrock123 merged commit 5e5ec2c into nodejs:master Jun 30, 2016

@Fishrock123 Fishrock123 deleted the Fishrock123:os-deprecate-tmpDir branch Jun 30, 2016

@kellyselden kellyselden referenced this pull request Oct 29, 2016

Merged

tmpDir => tmpdir #28

rudidude86 pushed a commit to rudidude86/grunt-phplint that referenced this pull request Jan 16, 2017

Ryan Rud
os.tmpDir() - deprecated jgable#26
* call [`os.tmpdir()`](https://nodejs.org/api/os.html#os_os_tmpdir) instead of the [deprecated `os.tmpDir()` alias](nodejs/node#6739)
* include newer version of cache-swap with [tmpDir -> tmpdir issue fixed](jgable/cache-swap@69fab2b)

rudidude86 pushed a commit to rudidude86/grunt-phplint that referenced this pull request Jan 16, 2017

Ryan Rud Ryan Rud
os.tmpDir() - deprecated jgable#26
* call [`os.tmpdir()`](https://nodejs.org/api/os.html#os_os_tmpdir) instead of the [deprecated `os.tmpDir()` alias](nodejs/node#6739)
* include newer version of cache-swap with [tmpDir -> tmpdir issue fixed](jgable/cache-swap@69fab2b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment