Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix 6899: console.* not working when running out of stack space #6907
Affected core subsystem(s)
vm, module(?), console(?)
Description of change
Commit 1: vm: don't abort process when stack space runs out
Make less assumptions about what objects will be available when vm context creation or error message printing fail because V8 runs out of JS stack space.
Commit 2: module: don't cache uninitialized builtins
Don't cache the exported values of fully uninitialized builtins. This works by adding an additional
This has the effect that builtins modules which could not be loaded (e.g. because compilation failed due to missing stack space) can be loaded at a later point.
I’m definitely open for the possibility of leaving the
Initial CI: https://ci.nodejs.org/job/node-test-commit/3417/