New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve rendering of v4.4.5 changelog entry #6958

Merged
merged 1 commit into from Jun 1, 2016

Conversation

Projects
None yet
4 participants
@MylesBorins
Member

MylesBorins commented May 24, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Remove extra newlines that were causing rendering problems.

@MylesBorins

This comment has been minimized.

Member

MylesBorins commented May 24, 2016

@Fishrock123

This comment has been minimized.

Member

Fishrock123 commented May 24, 2016

lgtm

MylesBorins added a commit to MylesBorins/nodejs.org that referenced this pull request May 24, 2016

MylesBorins added a commit to MylesBorins/nodejs.org that referenced this pull request May 24, 2016

@addaleax

This comment has been minimized.

Member

addaleax commented May 25, 2016

While you’re changing this anyway, could you also change the “notable changes” text for the buffer thing? In v4, only .indexOf is by us, .lastIndexOf is from Uint8Array, so the only changes that were backported were for .indexOf with UTF-16 encoding… maybe something along the lines of

Buffer.indexOf now returns correct values for all UTF-16 input?

Sorry for not catching that earlier.

@MylesBorins MylesBorins force-pushed the MylesBorins:fix-changelog branch Jun 1, 2016

@MylesBorins

This comment has been minimized.

Member

MylesBorins commented Jun 1, 2016

@addaleax updated... PTAL

@addaleax

This comment has been minimized.

Member

addaleax commented Jun 1, 2016

@thealphanerd Looks good, thanks!

@MylesBorins MylesBorins force-pushed the MylesBorins:fix-changelog branch 2 times, most recently to 8c1d5e5 Jun 1, 2016

doc: improve rendering of v4.4.5 changelog entry
Remove extra newlines that were causing rendering problems.

PR-URL: #6958
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

@MylesBorins MylesBorins merged commit 8c1d5e5 into nodejs:master Jun 1, 2016

MylesBorins added a commit that referenced this pull request Jun 1, 2016

doc: improve rendering of v4.4.5 changelog entry
Remove extra newlines that were causing rendering problems.

PR-URL: #6958
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

@MylesBorins MylesBorins deleted the MylesBorins:fix-changelog branch Jun 13, 2016

MylesBorins added a commit that referenced this pull request Jun 23, 2016

doc: improve rendering of v4.4.5 changelog entry
Remove extra newlines that were causing rendering problems.

PR-URL: #6958
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins added a commit that referenced this pull request Jun 24, 2016

doc: improve rendering of v4.4.5 changelog entry
Remove extra newlines that were causing rendering problems.

PR-URL: #6958
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

@MylesBorins MylesBorins referenced this pull request Jun 24, 2016

Merged

v4.4.7 proposal #7395

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment