New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Provide bad/better examples for access() and exists() #7832

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@dfabulich
Contributor

dfabulich commented Jul 22, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change
@jasnell

View changes

Show outdated Hide outdated doc/api/fs.md
@jasnell

View changes

Show outdated Hide outdated doc/api/fs.md
@jasnell

View changes

Show outdated Hide outdated doc/api/fs.md
@jasnell

View changes

Show outdated Hide outdated doc/api/fs.md
@jasnell

View changes

Show outdated Hide outdated doc/api/fs.md
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 5, 2016

Member

Thank you for this, left some comments! Sorry it has take so long for someone to take a look and get back to you.

Member

jasnell commented Aug 5, 2016

Thank you for this, left some comments! Sorry it has take so long for someone to take a look and get back to you.

@dfabulich

This comment has been minimized.

Show comment
Hide comment
@dfabulich

dfabulich Aug 9, 2016

Contributor

@jasnell Thanks for your feedback. I've incorporated your comments in the latest draft.

Contributor

dfabulich commented Aug 9, 2016

@jasnell Thanks for your feedback. I've incorporated your comments in the latest draft.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 11, 2016

Member

@dfabulich .. thank you! will be able to go through in detail again tomorrow :-)

Member

jasnell commented Aug 11, 2016

@dfabulich .. thank you! will be able to go through in detail again tomorrow :-)

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123
Member

Fishrock123 commented Aug 22, 2016

ping @jasnell

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 22, 2016

Member

Whoops, let this one slip off my radar. LGTM

Member

jasnell commented Aug 22, 2016

Whoops, let this one slip off my radar. LGTM

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell
Member

jasnell commented Aug 24, 2016

@addaleax

View changes

Show outdated Hide outdated doc/api/fs.md
@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Aug 25, 2016

Member

LGTM with a suggestion, thanks for putting these together!

Member

addaleax commented Aug 25, 2016

LGTM with a suggestion, thanks for putting these together!

@thefourtheye

View changes

Show outdated Hide outdated doc/api/fs.md
@dfabulich

This comment has been minimized.

Show comment
Hide comment
@dfabulich

dfabulich Aug 31, 2016

Contributor

Incorporated feedback from @addaleax and @thefourtheye

Contributor

dfabulich commented Aug 31, 2016

Incorporated feedback from @addaleax and @thefourtheye

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 1, 2016

Member

LGTM! will get this landed!

Member

jasnell commented Sep 1, 2016

LGTM! will get this landed!

jasnell added a commit that referenced this pull request Sep 1, 2016

doc: bad/better examples for fs.access() and fs.exists()
PR-URL: #7832
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 1, 2016

Member

Landed in 143d38c. Thank you!

Member

jasnell commented Sep 1, 2016

Landed in 143d38c. Thank you!

@jasnell jasnell closed this Sep 1, 2016

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

doc: bad/better examples for fs.access() and fs.exists()
PR-URL: nodejs#7832
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

doc: bad/better examples for fs.access() and fs.exists()
PR-URL: #7832
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins added a commit that referenced this pull request Sep 30, 2016

doc: bad/better examples for fs.access() and fs.exists()
PR-URL: #7832
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Sep 30, 2016

Member

I've landed this on v4.x-staging as it appears to be accurate. Please let me know if it is not

Member

MylesBorins commented Sep 30, 2016

I've landed this on v4.x-staging as it appears to be accurate. Please let me know if it is not

MylesBorins added a commit that referenced this pull request Oct 10, 2016

doc: bad/better examples for fs.access() and fs.exists()
PR-URL: #7832
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

rvagg added a commit that referenced this pull request Oct 18, 2016

doc: bad/better examples for fs.access() and fs.exists()
PR-URL: #7832
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins added a commit that referenced this pull request Oct 26, 2016

doc: bad/better examples for fs.access() and fs.exists()
PR-URL: #7832
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@MylesBorins MylesBorins referenced this pull request Oct 26, 2016

Closed

V4.6.2 proposal #9298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment