Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
meta: whitelist dotfiles in .gitignore #8016
@silverwind It works only because those files are either already present in git or present in the whitelist.
$ git rm ./test/fixtures/.empty-repl-history-file rm 'test/fixtures/.empty-repl-history-file' $ touch ./test/fixtures/.empty-repl-history-file $ git add ./test/fixtures/.empty-repl-history-file The following paths are ignored by one of your .gitignore files: test/fixtures/.empty-repl-history-file Use -f if you really want to add them.
This PR should whitelist all the dot-prefixed-files that we already have in git, not just the top-level ones.
Yes, I agree that's needed. Searching dotfiles in the tree, there might be a few more we ought to include. Or better yet, exclude
$ find . -name ".*" | xargs basename | sort | uniq
(partially cleaned up)
I think this should be a more or less complete list of "good" files:
And a list of directories to keep dotfiles from:
We should check that nothing of those was targeted towards the files that are being whitelisted now (i.e. deps/, test/, tools/).
referenced this pull request
Oct 16, 2016
I'm rebuilding to confirm, but AFAICT, after doing a
Granted, this happened before the change, but if we're improving the .gitignore file, why not make it work?
As for the change to whitelisting, I'm +0 on it. It supports people who haven't added their editor's temp files to their