build: add missing files to zip and 7z packages #8069

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
7 participants
@richardlau
Member

richardlau commented Aug 11, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign package (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Description of change

Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man
to the zip and 7z packages. These files are already being installed by the msi
installer (with default options).

build: add missing files to zip and 7z packages
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man
to the zip and 7z packages.
@@ -126,6 +126,8 @@ if "%target%"=="Clean" rmdir /S /Q %~dp0deps\icu
call :getnodeversion || exit /b 1
+if "%target%"=="Clean" rmdir /Q /S "%~dp0%config%\node-v%FULLVERSION%-win-%target_arch%" > nul 2> nul

This comment has been minimized.

@bzoz

bzoz Aug 12, 2016

Contributor

On my box this deletes only Release\node-v7.0.0-win-x64, leaving other configurations

@bzoz

bzoz Aug 12, 2016

Contributor

On my box this deletes only Release\node-v7.0.0-win-x64, leaving other configurations

This comment has been minimized.

@richardlau

richardlau Aug 12, 2016

Member

clean will clear stuff under the selected configuration config (which defaults to Release unless debug is passed as an argument to vcbuild.bat). This is consistent with msbuild which only clears out the object files for the selected configuration with clean.

@richardlau

richardlau Aug 12, 2016

Member

clean will clear stuff under the selected configuration config (which defaults to Release unless debug is passed as an argument to vcbuild.bat). This is consistent with msbuild which only clears out the object files for the selected configuration with clean.

This comment has been minimized.

@bzoz

bzoz Aug 17, 2016

Contributor

Ok, then LGTM

@bzoz

bzoz Aug 17, 2016

Contributor

Ok, then LGTM

@bzoz

This comment has been minimized.

Show comment
Hide comment
@bzoz

bzoz Aug 12, 2016

Contributor

Added a comment about Clean, otherwise LGTM

Contributor

bzoz commented Aug 12, 2016

Added a comment about Clean, otherwise LGTM

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Aug 12, 2016

Member

@orangemocha @joaocgreis can you take a look and comment.

Member

mhdawson commented Aug 12, 2016

@orangemocha @joaocgreis can you take a look and comment.

@joaocgreis

This comment has been minimized.

Show comment
Hide comment
@joaocgreis

joaocgreis Aug 17, 2016

Member

LGTM

Note that the MSI installs the manifests in the system. Here, they will have to be installed manually by users. I think it's good to enable them to.

Member

joaocgreis commented Aug 17, 2016

LGTM

Note that the MSI installs the manifests in the system. Here, they will have to be installed manually by users. I think it's good to enable them to.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 17, 2016

Member

LGTM

Member

jasnell commented Aug 17, 2016

LGTM

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Aug 25, 2016

Member

LGTM, will land.

Member

mhdawson commented Aug 25, 2016

LGTM, will land.

@mhdawson mhdawson self-assigned this Aug 25, 2016

@mhdawson

This comment has been minimized.

Show comment
Hide comment

mhdawson added a commit that referenced this pull request Aug 25, 2016

build: add missing files to zip and 7z packages
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man
to the zip and 7z packages.

PR-URL: #8069
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: joaocgreis - João Reis <reis@janeasystems.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Aug 25, 2016

Member

CI run was good, landed as 18017d6

Member

mhdawson commented Aug 25, 2016

CI run was good, landed as 18017d6

@mhdawson mhdawson closed this Aug 25, 2016

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

build: add missing files to zip and 7z packages
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man
to the zip and 7z packages.

PR-URL: nodejs#8069
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: joaocgreis - João Reis <reis@janeasystems.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

build: add missing files to zip and 7z packages
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man
to the zip and 7z packages.

PR-URL: #8069
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: joaocgreis - João Reis <reis@janeasystems.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Sep 30, 2016

Member

@richardlau should this be backported?

Member

MylesBorins commented Sep 30, 2016

@richardlau should this be backported?

@richardlau

This comment has been minimized.

Show comment
Hide comment
@richardlau

richardlau Oct 1, 2016

Member

@thealphanerd Yes, please

Member

richardlau commented Oct 1, 2016

@thealphanerd Yes, please

MylesBorins added a commit that referenced this pull request Oct 10, 2016

build: add missing files to zip and 7z packages
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man
to the zip and 7z packages.

PR-URL: #8069
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: joaocgreis - João Reis <reis@janeasystems.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

rvagg added a commit that referenced this pull request Oct 18, 2016

build: add missing files to zip and 7z packages
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man
to the zip and 7z packages.

PR-URL: #8069
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: joaocgreis - João Reis <reis@janeasystems.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins added a commit that referenced this pull request Oct 26, 2016

build: add missing files to zip and 7z packages
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man
to the zip and 7z packages.

PR-URL: #8069
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: joaocgreis - João Reis <reis@janeasystems.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@MylesBorins MylesBorins referenced this pull request Oct 26, 2016

Closed

V4.6.2 proposal #9298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment