url: make `url.format()` encode all occurrences of `#` in `search` #8072

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants
@imyller
Member

imyller commented Aug 11, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

url

Description of change

This fixes an error where the first occurrence of # in search parameter is URL encoded, and subsequent occurrences are not.

Also added a test for the case.

Fixes: #8064

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Aug 11, 2016

Member

I think the changes here look good, but you may want to shorten the subject line of the commit message to no more than 50 characters and use a full URL for the referenced github issue.

Member

addaleax commented Aug 11, 2016

I think the changes here look good, but you may want to shorten the subject line of the commit message to no more than 50 characters and use a full URL for the referenced github issue.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 11, 2016

Member

LGTM with the nit @addaleax mentions fixed. We'll definitely need a CITGM run on this (@thealphanerd)

Member

jasnell commented Aug 11, 2016

LGTM with the nit @addaleax mentions fixed. We'll definitely need a CITGM run on this (@thealphanerd)

url: `url.format()` encodes all `#` in `search`
This commit Fixes an error where only the first occurrence of `#` in
`search` parameter is URL encoded, and subsequent occurrences are not.

Also added a test for the case.

Fixes: #8064

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
@imyller

This comment has been minimized.

Show comment
Hide comment
@imyller

imyller Aug 11, 2016

Member

@addaleax Thanks for pointing those out. Fixed.

Member

imyller commented Aug 11, 2016

@addaleax Thanks for pointing those out. Fixed.

@imyller

This comment has been minimized.

Show comment
Hide comment
@imyller

imyller Aug 11, 2016

Member

CI check failure with RasPi seems to be unrelated to this PR:

https://ci.nodejs.org/job/node-test-binary-arm/RUN_SUBSET=addons,label=pi2-raspbian-wheezy/3263/console

https://ci.nodejs.org/job/node-test-binary-arm/RUN_SUBSET=addons,label=pi1-raspbian-wheezy/3263/console

+ make test-ci-native
Makefile:77: *** Stale config.gypi, please re-run ./configure.  Stop.
Build step 'Execute shell' marked build as failure
Member

imyller commented Aug 11, 2016

CI check failure with RasPi seems to be unrelated to this PR:

https://ci.nodejs.org/job/node-test-binary-arm/RUN_SUBSET=addons,label=pi2-raspbian-wheezy/3263/console

https://ci.nodejs.org/job/node-test-binary-arm/RUN_SUBSET=addons,label=pi1-raspbian-wheezy/3263/console

+ make test-ci-native
Makefile:77: *** Stale config.gypi, please re-run ./configure.  Stop.
Build step 'Execute shell' marked build as failure
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 18, 2016

Member

CITGM looks good. Only known expected failures. Still LGTM

Member

jasnell commented Aug 18, 2016

CITGM looks good. Only known expected failures. Still LGTM

@jasnell

This comment has been minimized.

Show comment
Hide comment
Member

jasnell commented Aug 18, 2016

jasnell added a commit that referenced this pull request Aug 18, 2016

url: `url.format()` encodes all `#` in `search`
This commit Fixes an error where only the first occurrence of `#` in
`search` parameter is URL encoded, and subsequent occurrences are not.

Also added a test for the case.

Fixes: #8064
PR-URL: #8072
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 18, 2016

Member

Landed in 1d0385f

Member

jasnell commented Aug 18, 2016

Landed in 1d0385f

@jasnell jasnell closed this Aug 18, 2016

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

url: `url.format()` encodes all `#` in `search`
This commit Fixes an error where only the first occurrence of `#` in
`search` parameter is URL encoded, and subsequent occurrences are not.

Also added a test for the case.

Fixes: nodejs#8064
PR-URL: nodejs#8072
Reviewed-By: James M Snell <jasnell@gmail.com>

 Conflicts:
	test/parallel/test-url.js

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

url: `url.format()` encodes all `#` in `search`
This commit Fixes an error where only the first occurrence of `#` in
`search` parameter is URL encoded, and subsequent occurrences are not.

Also added a test for the case.

Fixes: #8064
PR-URL: #8072
Reviewed-By: James M Snell <jasnell@gmail.com>

 Conflicts:
	test/parallel/test-url.js

MylesBorins added a commit that referenced this pull request Sep 30, 2016

url: `url.format()` encodes all `#` in `search`
This commit Fixes an error where only the first occurrence of `#` in
`search` parameter is URL encoded, and subsequent occurrences are not.

Also added a test for the case.

Fixes: #8064
PR-URL: #8072
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 30, 2016

url: `url.format()` encodes all `#` in `search`
This commit Fixes an error where only the first occurrence of `#` in
`search` parameter is URL encoded, and subsequent occurrences are not.

Also added a test for the case.

Fixes: #8064
PR-URL: #8072
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 10, 2016

url: `url.format()` encodes all `#` in `search`
This commit Fixes an error where only the first occurrence of `#` in
`search` parameter is URL encoded, and subsequent occurrences are not.

Also added a test for the case.

Fixes: #8064
PR-URL: #8072
Reviewed-By: James M Snell <jasnell@gmail.com>

rvagg added a commit that referenced this pull request Oct 18, 2016

url: `url.format()` encodes all `#` in `search`
This commit Fixes an error where only the first occurrence of `#` in
`search` parameter is URL encoded, and subsequent occurrences are not.

Also added a test for the case.

Fixes: #8064
PR-URL: #8072
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 26, 2016

url: `url.format()` encodes all `#` in `search`
This commit Fixes an error where only the first occurrence of `#` in
`search` parameter is URL encoded, and subsequent occurrences are not.

Also added a test for the case.

Fixes: #8064
PR-URL: #8072
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Oct 26, 2016

Closed

V4.6.2 proposal #9298

MylesBorins added a commit that referenced this pull request Oct 26, 2016

2016-10-26, Version 4.6.2 'Argon' (LTS)
This LTS release comes with 219 commits. This includes 80 commits that
are docs related, 58 commits that are test related, 20 commits that
are build / tool related, and 9 commits that are updates to
dependencies.

Notable Changes

* build:
  - It is now possible to build the documentation from the release
    tarball (Anna Henningsen)
    #8413
* buffer:
  - Buffer will no longer incorrectly return a zero filled buffer when
    an encoding is passed (Teddy Katz)
    #9238
* deps:
  - upgrade npm in LTS to 2.15.11 (Kat Marchán)
    #8928
* repl:
  - Enable tab completion for global properties (Lance Ball)
    #7369
* url:
  - `url.format()` will now encode all `#` in `search` (Ilkka Myller)
    #8072

PR-URL: #9298

MylesBorins added a commit that referenced this pull request Oct 26, 2016

2016-10-26, Version 4.6.2 'Argon' (LTS)
This LTS release comes with 219 commits. This includes 80 commits that
are docs related, 58 commits that are test related, 20 commits that
are build / tool related, and 9 commits that are updates to
dependencies.

Notable Changes

* build:
  - It is now possible to build the documentation from the release
    tarball (Anna Henningsen)
    #8413
* buffer:
  - Buffer.alloc() will no longer incorrectly return a zero filled
    buffer when an encoding is passed (Teddy Katz)
    #9238
* deps:
  - upgrade npm in LTS to 2.15.11 (Kat Marchán)
    #8928
* repl:
  - Enable tab completion for global properties (Lance Ball)
    #7369
* url:
  - `url.format()` will now encode all `#` in `search` (Ilkka Myller)
    #8072

PR-URL: #9298

MylesBorins added a commit that referenced this pull request Nov 7, 2016

2016-11-08, Version 4.6.2 'Argon' (LTS)
This LTS release comes with 219 commits. This includes 80 commits that
are docs related, 58 commits that are test related, 20 commits that
are build / tool related, and 9 commits that are updates to
dependencies.

Notable Changes

* build:
  - It is now possible to build the documentation from the release
    tarball (Anna Henningsen)
    #8413
* buffer:
  - Buffer.alloc() will no longer incorrectly return a zero filled
    buffer when an encoding is passed (Teddy Katz)
    #9238
* deps:
  - upgrade npm in LTS to 2.15.11 (Kat Marchán)
    #8928
* repl:
  - Enable tab completion for global properties (Lance Ball)
    #7369
* url:
  - `url.format()` will now encode all `#` in `search` (Ilkka Myller)
    #8072

PR-URL: #9298

MylesBorins added a commit that referenced this pull request Nov 8, 2016

2016-11-08, Version 4.6.2 'Argon' (LTS)
This LTS release comes with 219 commits. This includes 80 commits that
are docs related, 58 commits that are test related, 20 commits that
are build / tool related, and 9 commits that are updates to
dependencies.

Notable Changes

* build:
  - It is now possible to build the documentation from the release
    tarball (Anna Henningsen)
    #8413
* buffer:
  - Buffer.alloc() will no longer incorrectly return a zero filled
    buffer when an encoding is passed (Teddy Katz)
    #9238
* deps:
  - upgrade npm in LTS to 2.15.11 (Kat Marchán)
    #8928
* repl:
  - Enable tab completion for global properties (Lance Ball)
    #7369
* url:
  - `url.format()` will now encode all `#` in `search` (Ilkka Myller)
    #8072

PR-URL: #9298

imyller added a commit to imyller/meta-nodejs that referenced this pull request Nov 11, 2016

2016-11-08, Version 4.6.2 'Argon' (LTS)
    This LTS release comes with 219 commits. This includes 80 commits that
    are docs related, 58 commits that are test related, 20 commits that
    are build / tool related, and 9 commits that are updates to
    dependencies.

    Notable Changes

    * build:
      - It is now possible to build the documentation from the release
        tarball (Anna Henningsen)
        nodejs/node#8413
    * buffer:
      - Buffer.alloc() will no longer incorrectly return a zero filled
        buffer when an encoding is passed (Teddy Katz)
        nodejs/node#9238
    * deps:
      - upgrade npm in LTS to 2.15.11 (Kat Marchan)
        nodejs/node#8928
    * repl:
      - Enable tab completion for global properties (Lance Ball)
        nodejs/node#7369
    * url:
      - `url.format()` will now encode all `#` in `search` (Ilkka Myller)
        nodejs/node#8072

    PR-URL: nodejs/node#9298

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment