New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async_wrap: add a missing case to test-async-wrap-throw-no-init #8198

Merged
merged 1 commit into from Aug 25, 2016

Conversation

Projects
None yet
5 participants
@yorkie
Member

yorkie commented Aug 20, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

async_wrap, test

Description of change

This covers this line in "src/async-wrap.cc". /R= @trevnorris

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 21, 2016

Member

LGTM if CI is green.

Member

jasnell commented Aug 21, 2016

LGTM if CI is green.

@yorkie

This comment has been minimized.

Show comment
Hide comment
@yorkie

yorkie Aug 22, 2016

Member

The CI seems to fail on the following errors:

Member

yorkie commented Aug 22, 2016

The CI seems to fail on the following errors:

@yorkie

This comment has been minimized.

Show comment
Hide comment
@yorkie

yorkie Aug 22, 2016

Member

@jasnell The arm-fanned issue seems to be tried to fix at #8203, but another seems fresh, so I opened #8219 to track that.

Member

yorkie commented Aug 22, 2016

@jasnell The arm-fanned issue seems to be tried to fix at #8203, but another seems fresh, so I opened #8219 to track that.

@trevnorris

This comment has been minimized.

Show comment
Hide comment
@trevnorris

trevnorris Aug 22, 2016

Contributor

LGTM

Contributor

trevnorris commented Aug 22, 2016

LGTM

@yorkie

This comment has been minimized.

Show comment
Hide comment
@yorkie
Member

yorkie commented Aug 23, 2016

async_wrap: add a missing case to test-async-wrap-throw-no-init
PR-URL: #8198
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>

@yorkie yorkie merged commit 10b3f13 into nodejs:master Aug 25, 2016

@yorkie yorkie deleted the yorkie:test-async-wrap-throw-no-init branch Aug 25, 2016

@yorkie

This comment has been minimized.

Show comment
Hide comment
@yorkie

yorkie Aug 25, 2016

Member

Landed at 10b3f13, thanks for reviews :)

Member

yorkie commented Aug 25, 2016

Landed at 10b3f13, thanks for reviews :)

@yorkie

This comment has been minimized.

Show comment
Hide comment
@yorkie

yorkie Aug 25, 2016

Member

Needs help with the CI failure, the CI seems to fail on AIX, here is the log of failed build. I remember that this CI#3815 was green but now it has failure. /cc @nodejs/build

Member

yorkie commented Aug 25, 2016

Needs help with the CI failure, the CI seems to fail on AIX, here is the log of failed build. I remember that this CI#3815 was green but now it has failure. /cc @nodejs/build

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

async_wrap: add a missing case to test-async-wrap-throw-no-init
PR-URL: nodejs#8198
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

async_wrap: add a missing case to test-async-wrap-throw-no-init
PR-URL: #8198
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 30, 2016

async_wrap: add a missing case to test-async-wrap-throw-no-init
PR-URL: #8198
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Sep 30, 2016

Member

I've landed this on v4.x-staging. @trevnorris @yorkie let me know if it should not have landed

Member

MylesBorins commented Sep 30, 2016

I've landed this on v4.x-staging. @trevnorris @yorkie let me know if it should not have landed

MylesBorins added a commit that referenced this pull request Oct 10, 2016

async_wrap: add a missing case to test-async-wrap-throw-no-init
PR-URL: #8198
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>

rvagg added a commit that referenced this pull request Oct 18, 2016

async_wrap: add a missing case to test-async-wrap-throw-no-init
PR-URL: #8198
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 26, 2016

async_wrap: add a missing case to test-async-wrap-throw-no-init
PR-URL: #8198
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>

@MylesBorins MylesBorins referenced this pull request Oct 26, 2016

Closed

V4.6.2 proposal #9298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment