http: fix connection upgrade checks #8238

Merged
merged 1 commit into from Aug 26, 2016

Conversation

Projects
None yet
3 participants
@mscdex
Contributor

mscdex commented Aug 23, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)
  • http
Description of change

This commit fixes connection upgrade checks, specifically when headers are passed as an array instead of a plain object to http.request().

Fixes: #8235

@mscdex mscdex added the http label Aug 23, 2016

@mscdex

This comment has been minimized.

Show comment
Hide comment
@mscdex

mscdex Aug 23, 2016

Contributor
Contributor

mscdex commented Aug 23, 2016

@mscdex

This comment has been minimized.

Show comment
Hide comment
@mscdex

This comment has been minimized.

Show comment
Hide comment
@mscdex

mscdex Aug 23, 2016

Contributor

CI is green except for an unrelated failure on AIX.

Contributor

mscdex commented Aug 23, 2016

CI is green except for an unrelated failure on AIX.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 23, 2016

Member

LGTM

Member

jasnell commented Aug 23, 2016

LGTM

http: fix connection upgrade checks
This commit Fixes connection upgrade checks, specifically when headers
are passed as an array instead of a plain object to http.request()

Fixes: #8235
PR-URL: #8238
Reviewed-By: James M Snell <jasnell@gmail.com>

@mscdex mscdex merged commit 1050594 into nodejs:master Aug 26, 2016

@mscdex mscdex deleted the mscdex:http-add-headers-guard branch Aug 26, 2016

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

http: fix connection upgrade checks
This commit Fixes connection upgrade checks, specifically when headers
are passed as an array instead of a plain object to http.request()

Fixes: nodejs#8235
PR-URL: nodejs#8238
Reviewed-By: James M Snell <jasnell@gmail.com>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

http: fix connection upgrade checks
This commit Fixes connection upgrade checks, specifically when headers
are passed as an array instead of a plain object to http.request()

Fixes: #8235
PR-URL: #8238
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Oct 10, 2016

Member

@mscdex this does not land cleanly on v4.x, but we definitely should backport as I have confirmed it is broken on v4.x

Would you be able to backport?

Member

MylesBorins commented Oct 10, 2016

@mscdex this does not land cleanly on v4.x, but we definitely should backport as I have confirmed it is broken on v4.x

Would you be able to backport?

@MylesBorins MylesBorins added this to the v4.6.2 milestone Oct 24, 2016

@MylesBorins MylesBorins modified the milestones: v4.7.0, v4.6.2 Oct 26, 2016

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
Member

MylesBorins commented Nov 14, 2016

ping @mscdex

mscdex added a commit to mscdex/io.js that referenced this pull request Nov 18, 2016

http: fix connection upgrade checks
This commit Fixes connection upgrade checks, specifically when headers
are passed as an array instead of a plain object to http.request()

Fixes: nodejs#8235
PR-URL: nodejs#8238
Reviewed-By: James M Snell <jasnell@gmail.com>

@mscdex mscdex referenced this pull request Nov 18, 2016

Closed

backport: http: fix connection upgrade checks #9681

3 of 3 tasks complete
@mscdex

This comment has been minimized.

Show comment
Hide comment
Contributor

mscdex commented Nov 18, 2016

MylesBorins added a commit that referenced this pull request Nov 22, 2016

http: fix connection upgrade checks
This commit Fixes connection upgrade checks, specifically when headers
are passed as an array instead of a plain object to http.request()

Fixes: #8235
PR-URL: #8238
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins removed this from the 4.7.0 milestone Nov 22, 2016

@MylesBorins MylesBorins referenced this pull request Nov 22, 2016

Merged

v4.7.0 proposal #9736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment