New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix buf.readUIntBE, buf.readUIntLE examples #8240

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@mozkeeler
Contributor

mozkeeler commented Aug 23, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

The documentation describing the output from the examples for
buf.readUIntBE and buf.readUIntLE were switched in terms of what the
code would actually output. This patch addresses this by switching the
two lines of example code to be in the same order as the functions are
listed earlier in the documentation.

doc: fix buf.readUIntBE, buf.readUIntLE examples
The documentation describing the output from the examples for
buf.readUIntBE and buf.readUIntLE were switched in terms of what the
code would actually output. This patch addresses this by switching the
two lines of example code to be in the same order as the functions are
listed earlier in the documentation.
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 23, 2016

Member

LGTM

Member

jasnell commented Aug 23, 2016

LGTM

@mscdex

This comment has been minimized.

Show comment
Hide comment
@mscdex

mscdex Aug 23, 2016

Contributor

LGTM

Contributor

mscdex commented Aug 23, 2016

LGTM

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Aug 24, 2016

Contributor

LGTM

Contributor

cjihrig commented Aug 24, 2016

LGTM

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Aug 24, 2016

Member

Thanks, looks good to me too!

Member

addaleax commented Aug 24, 2016

Thanks, looks good to me too!

@princejwesley

This comment has been minimized.

Show comment
Hide comment
@princejwesley

princejwesley Aug 24, 2016

Contributor

LGTM

Contributor

princejwesley commented Aug 24, 2016

LGTM

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Aug 25, 2016

Member

Landed in 7f1bb80, thanks for the PR!

Member

addaleax commented Aug 25, 2016

Landed in 7f1bb80, thanks for the PR!

@addaleax addaleax closed this Aug 25, 2016

addaleax added a commit that referenced this pull request Aug 25, 2016

doc: fix buf.readUIntBE, buf.readUIntLE examples
The documentation describing the output from the examples for
buf.readUIntBE and buf.readUIntLE were switched in terms of what the
code would actually output. This patch addresses this by switching the
two lines of example code to be in the same order as the functions are
listed earlier in the documentation.

PR-URL: #8240
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
@mozkeeler

This comment has been minimized.

Show comment
Hide comment
@mozkeeler

mozkeeler Aug 25, 2016

Contributor

Thanks!

Contributor

mozkeeler commented Aug 25, 2016

Thanks!

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

doc: fix buf.readUIntBE, buf.readUIntLE examples
The documentation describing the output from the examples for
buf.readUIntBE and buf.readUIntLE were switched in terms of what the
code would actually output. This patch addresses this by switching the
two lines of example code to be in the same order as the functions are
listed earlier in the documentation.

PR-URL: nodejs#8240
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

doc: fix buf.readUIntBE, buf.readUIntLE examples
The documentation describing the output from the examples for
buf.readUIntBE and buf.readUIntLE were switched in terms of what the
code would actually output. This patch addresses this by switching the
two lines of example code to be in the same order as the functions are
listed earlier in the documentation.

PR-URL: #8240
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment