New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add `added:` information for modules #8250

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@lpinca
Member

lpinca commented Aug 24, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Ref: #6578

@addaleax addaleax added module and removed modules labels Aug 24, 2016

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Aug 24, 2016

Member

Rubber-stamp LGTM, and thanks for picking these up!

Member

addaleax commented Aug 24, 2016

Rubber-stamp LGTM, and thanks for picking these up!

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Aug 24, 2016

Member

@phillipj The GH bot might need to be tweaked a bit to label changes to doc/api/modules.md correctly?

Member

addaleax commented Aug 24, 2016

@phillipj The GH bot might need to be tweaked a bit to label changes to doc/api/modules.md correctly?

@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca Aug 24, 2016

Member

I wonder if it makes sense to add the added: info for the module wrapper. I don't think so as it's not a public API.

Member

lpinca commented Aug 24, 2016

I wonder if it makes sense to add the added: info for the module wrapper. I don't think so as it's not a public API.

@bengl

This comment has been minimized.

Show comment
Hide comment
@bengl

bengl Aug 24, 2016

Member

LGTM

Member

bengl commented Aug 24, 2016

LGTM

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 24, 2016

Member

LGTM

Member

jasnell commented Aug 24, 2016

LGTM

@phillipj

This comment has been minimized.

Show comment
Hide comment
@phillipj

phillipj Aug 25, 2016

Member

@addaleax thanks, I'll look into it!

Member

phillipj commented Aug 25, 2016

@addaleax thanks, I'll look into it!

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Aug 27, 2016

Member

Landed in df4880d, thanks!

Member

addaleax commented Aug 27, 2016

Landed in df4880d, thanks!

@addaleax addaleax closed this Aug 27, 2016

addaleax added a commit that referenced this pull request Aug 27, 2016

doc: add `added:` information for modules
PR-URL: #8250
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@lpinca lpinca deleted the lpinca:add/added-modules branch Aug 27, 2016

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

doc: add `added:` information for modules
PR-URL: nodejs#8250
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

doc: add `added:` information for modules
PR-URL: #8250
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 30, 2016

doc: add `added:` information for modules
PR-URL: #8250
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 10, 2016

doc: add `added:` information for modules
PR-URL: #8250
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

rvagg added a commit that referenced this pull request Oct 18, 2016

doc: add `added:` information for modules
PR-URL: #8250
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 26, 2016

doc: add `added:` information for modules
PR-URL: #8250
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Oct 26, 2016

Closed

V4.6.2 proposal #9298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment