New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add Myles Borins to the CTC #8260

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@rvagg
Member

rvagg commented Aug 24, 2016

This was voted on the CTC meeting this week so this PR just needs review, @thealphanerd can you check pls?

Congrats btw!

@ChALkeR

This comment has been minimized.

Show comment
Hide comment
@ChALkeR

ChALkeR Aug 24, 2016

Member

LGTM

Upd: yes, with removing the duplicate entry under Collaborators as @addaleax noted.

Member

ChALkeR commented Aug 24, 2016

LGTM

Upd: yes, with removing the duplicate entry under Collaborators as @addaleax noted.

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Aug 24, 2016

Member

I think Myles should be moved from the Collaborators list to the CTC members list, LGTM with that (and if @thealphanerd is happy with this, of course 😄)

And yep, congratulations!

Member

addaleax commented Aug 24, 2016

I think Myles should be moved from the Collaborators list to the CTC members list, LGTM with that (and if @thealphanerd is happy with this, of course 😄)

And yep, congratulations!

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 24, 2016

Member

+1 to the nit from @addaleax ... otherwise LGTM

Member

jasnell commented Aug 24, 2016

+1 to the nit from @addaleax ... otherwise LGTM

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Aug 24, 2016

Member

thank you all so much. very honored to be included!

On Wed, Aug 24, 2016, 9:03 PM James M Snell notifications@github.com
wrote:

+1 to the nit from @addaleax https://github.com/addaleax ... otherwise
LGTM


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8260 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAecV-sZHhNAydx0sJiVxXP70HY2Lce2ks5qjLGugaJpZM4JsccE
.

Member

MylesBorins commented Aug 24, 2016

thank you all so much. very honored to be included!

On Wed, Aug 24, 2016, 9:03 PM James M Snell notifications@github.com
wrote:

+1 to the nit from @addaleax https://github.com/addaleax ... otherwise
LGTM


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8260 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAecV-sZHhNAydx0sJiVxXP70HY2Lce2ks5qjLGugaJpZM4JsccE
.

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Aug 25, 2016

Member

also, lgtm

Member

MylesBorins commented Aug 25, 2016

also, lgtm

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 25, 2016

Member

pretty certain this one doesn't need the 48 hours... landing

Member

jasnell commented Aug 25, 2016

pretty certain this one doesn't need the 48 hours... landing

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 25, 2016

Member

Landed in 36086b2

Member

jasnell commented Aug 25, 2016

Landed in 36086b2

@jasnell jasnell closed this Aug 25, 2016

jasnell added a commit that referenced this pull request Aug 25, 2016

doc: add Myles Borins to the CTC
PR-URL: #8260
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Aug 25, 2016

Member

Looks like this was re-landed in 2367e6c with a force push.

Member

Trott commented Aug 25, 2016

Looks like this was re-landed in 2367e6c with a force push.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 25, 2016

Member

yep... accidentally botched the first one... thanks for updating the pr

Member

jasnell commented Aug 25, 2016

yep... accidentally botched the first one... thanks for updating the pr

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

doc: add Myles Borins to the CTC
PR-URL: nodejs#8260
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

doc: add Myles Borins to the CTC
PR-URL: #8260
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 30, 2016

doc: add Myles Borins to the CTC
PR-URL: #8260
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 10, 2016

doc: add Myles Borins to the CTC
PR-URL: #8260
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

rvagg added a commit that referenced this pull request Oct 18, 2016

doc: add Myles Borins to the CTC
PR-URL: #8260
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 26, 2016

doc: add Myles Borins to the CTC
PR-URL: #8260
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

@MylesBorins MylesBorins referenced this pull request Oct 26, 2016

Closed

V4.6.2 proposal #9298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment