New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix depenencies on AIX #8272

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@mhdawson
Member

mhdawson commented Aug 25, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Description of change

addon tests were starting to run before the node exp file
creation was complete. Add process_outputs_as_sources to
node_exp target to avoid this.
this.

Fixes: #8239

build: fix depenencies on AIX
addon tests were starting to run before the node exp file
creation was complete. Add process_outputs_as_sources to avoid
this.

@mhdawson mhdawson self-assigned this Aug 25, 2016

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Aug 25, 2016

Member

I'm assuming we can land this quickly as it resolves a regular issue in the CI, is low risk, only affects AIX and should not be controversial in any way.

Member

mhdawson commented Aug 25, 2016

I'm assuming we can land this quickly as it resolves a regular issue in the CI, is low risk, only affects AIX and should not be controversial in any way.

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Aug 25, 2016

Member

@bnoordhuis, @Trott can you take a look and L.G.T.M, if appropriate

Member

mhdawson commented Aug 25, 2016

@bnoordhuis, @Trott can you take a look and L.G.T.M, if appropriate

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Aug 25, 2016

Member

I'm assuming we can land this quickly as it resolves a regular issue in the CI, is low risk, only affects AIX and should not be controversial in any way.

Agreed that we should land it quickly.

LGTM. (My gyp knowledge is limited but this is also a very limited change.)

Member

Trott commented Aug 25, 2016

I'm assuming we can land this quickly as it resolves a regular issue in the CI, is low risk, only affects AIX and should not be controversial in any way.

Agreed that we should land it quickly.

LGTM. (My gyp knowledge is limited but this is also a very limited change.)

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Aug 25, 2016

Member

LGTM

Member

bnoordhuis commented Aug 25, 2016

LGTM

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Aug 25, 2016

Member

Commit message typo: depenencies

LGTM

Member

addaleax commented Aug 25, 2016

Commit message typo: depenencies

LGTM

@jbergstroem

This comment has been minimized.

Show comment
Hide comment
@jbergstroem
Member

jbergstroem commented Aug 25, 2016

LGTM

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Aug 25, 2016

Member

Commit message typo: depenencies

@addaleax You seem to catch typos in commit messages more than anyone else (probably more than everyone else combined), which I really appreciate. 🎉

Member

Trott commented Aug 25, 2016

Commit message typo: depenencies

@addaleax You seem to catch typos in commit messages more than anyone else (probably more than everyone else combined), which I really appreciate. 🎉

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 25, 2016

Member

You mean we're actually supposed to be reading the commit messages!? ;-)

Member

jasnell commented Aug 25, 2016

You mean we're actually supposed to be reading the commit messages!? ;-)

@mhdawson

This comment has been minimized.

Show comment
Hide comment
Member

mhdawson commented Aug 25, 2016

mhdawson added a commit that referenced this pull request Aug 25, 2016

build: fix dependencies on AIX
Addon tests were starting to run before the node exp file
creation was complete. Add process_outputs_as_sources to avoid
this.

Fixes: #8239
PR-URL: #8272
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Aug 25, 2016

Member

Landed as 063d14e

Member

mhdawson commented Aug 25, 2016

Landed as 063d14e

@mhdawson mhdawson closed this Aug 25, 2016

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

build: fix dependencies on AIX
Addon tests were starting to run before the node exp file
creation was complete. Add process_outputs_as_sources to avoid
this.

Fixes: nodejs#8239
PR-URL: nodejs#8272
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

build: fix dependencies on AIX
Addon tests were starting to run before the node exp file
creation was complete. Add process_outputs_as_sources to avoid
this.

Fixes: #8239
PR-URL: #8272
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

MylesBorins added a commit that referenced this pull request Sep 30, 2016

build: fix dependencies on AIX
Addon tests were starting to run before the node exp file
creation was complete. Add process_outputs_as_sources to avoid
this.

Fixes: #8239
PR-URL: #8272
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

MylesBorins added a commit that referenced this pull request Oct 10, 2016

build: fix dependencies on AIX
Addon tests were starting to run before the node exp file
creation was complete. Add process_outputs_as_sources to avoid
this.

Fixes: #8239
PR-URL: #8272
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

rvagg added a commit that referenced this pull request Oct 18, 2016

build: fix dependencies on AIX
Addon tests were starting to run before the node exp file
creation was complete. Add process_outputs_as_sources to avoid
this.

Fixes: #8239
PR-URL: #8272
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

MylesBorins added a commit that referenced this pull request Oct 26, 2016

build: fix dependencies on AIX
Addon tests were starting to run before the node exp file
creation was complete. Add process_outputs_as_sources to avoid
this.

Fixes: #8239
PR-URL: #8272
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

@MylesBorins MylesBorins referenced this pull request Oct 26, 2016

Closed

V4.6.2 proposal #9298

@mhdawson mhdawson deleted the mhdawson:aixaddon branch Mar 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment