New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark test-child-process-fork-dgram as flaky #8274

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@mhdawson
Member

mhdawson commented Aug 25, 2016

Checklist

  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

mark test-child-process-fork-dgram as flaky until we investigate/resolve
#8271

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Aug 25, 2016

Member

Again planning for a quick land since its simply marking a test as flaky and will help CI health.

Member

mhdawson commented Aug 25, 2016

Again planning for a quick land since its simply marking a test as flaky and will help CI health.

@jbergstroem

This comment has been minimized.

Show comment
Hide comment
@jbergstroem

jbergstroem Aug 25, 2016

Member

Something went wrong with last ci. New run: https://ci.nodejs.org/job/node-test-commit/4770/

Member

jbergstroem commented Aug 25, 2016

Something went wrong with last ci. New run: https://ci.nodejs.org/job/node-test-commit/4770/

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Aug 26, 2016

Member

CI ok except for ARM machine issue, so should be good to land.

Member

mhdawson commented Aug 26, 2016

CI ok except for ARM machine issue, so should be good to land.

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Aug 26, 2016

Member

Heading out for today, if there are enough oks by tomorrow will and first thing when I get in.

Member

mhdawson commented Aug 26, 2016

Heading out for today, if there are enough oks by tomorrow will and first thing when I get in.

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Aug 26, 2016

Contributor

LGTM

Contributor

cjihrig commented Aug 26, 2016

LGTM

@joaocgreis

This comment has been minimized.

Show comment
Hide comment
@joaocgreis

joaocgreis Aug 26, 2016

Member

LGTM

Member

joaocgreis commented Aug 26, 2016

LGTM

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Aug 26, 2016

Member

landed as 02ed21a

Member

mhdawson commented Aug 26, 2016

landed as 02ed21a

@mhdawson mhdawson closed this Aug 26, 2016

mhdawson added a commit that referenced this pull request Aug 26, 2016

test: mark test-child-process-fork-dgram as flaky
PR-URL: #8274
Reviewed-By: joaocgreis - João Reis <reis@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@mhdawson mhdawson self-assigned this Aug 26, 2016

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

test: mark test-child-process-fork-dgram as flaky
PR-URL: nodejs#8274
Reviewed-By: joaocgreis - João Reis <reis@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

test: mark test-child-process-fork-dgram as flaky
PR-URL: #8274
Reviewed-By: joaocgreis - João Reis <reis@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 10, 2016

test: mark test-child-process-fork-dgram as flaky
PR-URL: #8274
Reviewed-By: joaocgreis - João Reis <reis@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 10, 2016

test: mark test-child-process-fork-dgram as flaky
PR-URL: #8274
Reviewed-By: joaocgreis - João Reis <reis@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

rvagg added a commit that referenced this pull request Oct 18, 2016

test: mark test-child-process-fork-dgram as flaky
PR-URL: #8274
Reviewed-By: joaocgreis - João Reis <reis@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 26, 2016

test: mark test-child-process-fork-dgram as flaky
PR-URL: #8274
Reviewed-By: joaocgreis - João Reis <reis@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@MylesBorins MylesBorins referenced this pull request Oct 26, 2016

Closed

V4.6.2 proposal #9298

@mhdawson mhdawson deleted the mhdawson:fork-dgram branch Mar 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment