New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: additional refactoring/cleanup of buffer tests #8283

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@jasnell
Member

jasnell commented Aug 26, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test (buffer)

Description of change

Another round of cleanups for Buffer tests

  • Favor use of strictEqual where possible
  • Use const as appropriate
  • Other miscellaneous cleanups
test: additional refactoring/cleanup of buffer tests
* Favor use of strictEqual where possible
* Use const as appropriate
* Other miscellaneous cleanups
@jasnell

This comment has been minimized.

Show comment
Hide comment
@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Aug 27, 2016

Member

LGTM

Member

addaleax commented Aug 27, 2016

LGTM

@targos

This comment has been minimized.

Show comment
Hide comment
@targos

targos Aug 27, 2016

Member

LGTM

Member

targos commented Aug 27, 2016

LGTM

jasnell added a commit that referenced this pull request Aug 29, 2016

test: additional refactoring/cleanup of buffer tests
* Favor use of strictEqual where possible
* Use const as appropriate
* Other miscellaneous cleanups

PR-URL: #8283
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 29, 2016

Member

Landed in 4537cf2

Member

jasnell commented Aug 29, 2016

Landed in 4537cf2

@jasnell jasnell closed this Aug 29, 2016

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

test: additional refactoring/cleanup of buffer tests
* Favor use of strictEqual where possible
* Use const as appropriate
* Other miscellaneous cleanups

PR-URL: nodejs#8283
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

test: additional refactoring/cleanup of buffer tests
* Favor use of strictEqual where possible
* Use const as appropriate
* Other miscellaneous cleanups

PR-URL: #8283
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Sep 30, 2016

Member

not landing cleanly, feel free to backport

Member

MylesBorins commented Sep 30, 2016

not landing cleanly, feel free to backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment