test: refactor test-debug-signal-cluster #8289

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@Trott
Member

Trott commented Aug 26, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test debugger

Description of change

Notable changes include removing one (but not all) hard-coded ports, using common.fail(), and tidying conditionals and assertions.

@cjihrig

View changes

test/fixtures/clustered-server/app.js
+
+const http = require('http');
+const cluster = require('cluster');
+const common = require('../../common');

This comment has been minimized.

@cjihrig

cjihrig Aug 27, 2016

Contributor

Could you make common the first require().

@cjihrig

cjihrig Aug 27, 2016

Contributor

Could you make common the first require().

This comment has been minimized.

@Trott

Trott Aug 27, 2016

Member

Since this is a fixture file, common should probably be removed altogether!

@Trott

Trott Aug 27, 2016

Member

Since this is a fixture file, common should probably be removed altogether!

@cjihrig

View changes

test/parallel/test-debug-signal-cluster.js
+const spawn = require('child_process').spawn;
+
+const port = common.PORT;
+const args = ['--debug-port=' + port,

This comment has been minimized.

@cjihrig

cjihrig Aug 27, 2016

Contributor

You could make this a template literal if you want.

@cjihrig

cjihrig Aug 27, 2016

Contributor

You could make this a template literal if you want.

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Aug 27, 2016

Contributor

LGTM with a couple comments.

Contributor

cjihrig commented Aug 27, 2016

LGTM with a couple comments.

@Trott

This comment has been minimized.

Show comment
Hide comment
test: refactor test-debug-signal-cluster
Notable changes include removing one (but not all) hard-coded ports,
using `common.fail()`, and tidying conditionals and assertions.
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Aug 27, 2016

Member

Unfortunate build failures in CI, but nothing related to the changes here. Using the opportunity to rebase. CI again: https://ci.nodejs.org/job/node-test-pull-request/3852/

Member

Trott commented Aug 27, 2016

Unfortunate build failures in CI, but nothing related to the changes here. Using the opportunity to rebase. CI again: https://ci.nodejs.org/job/node-test-pull-request/3852/

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Aug 28, 2016

Member

(CI is green.)

Member

Trott commented Aug 28, 2016

(CI is green.)

@santigimeno

This comment has been minimized.

Show comment
Hide comment
Member

santigimeno commented Aug 29, 2016

LGTM

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 29, 2016

Member

LGTM

Member

jasnell commented Aug 29, 2016

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Aug 30, 2016

test: refactor test-debug-signal-cluster
Notable changes include removing one (but not all) hard-coded ports,
using `common.fail()`, and tidying conditionals and assertions.

PR-URL: nodejs#8289
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Aug 30, 2016

Member

Landed in e192825

Member

Trott commented Aug 30, 2016

Landed in e192825

@Trott Trott closed this Aug 30, 2016

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

test: refactor test-debug-signal-cluster
Notable changes include removing one (but not all) hard-coded ports,
using `common.fail()`, and tidying conditionals and assertions.

PR-URL: nodejs#8289
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

 Conflicts:
	test/parallel/test-debug-signal-cluster.js

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

test: refactor test-debug-signal-cluster
Notable changes include removing one (but not all) hard-coded ports,
using `common.fail()`, and tidying conditionals and assertions.

PR-URL: #8289
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

 Conflicts:
	test/parallel/test-debug-signal-cluster.js

MylesBorins added a commit that referenced this pull request Sep 30, 2016

test: refactor test-debug-signal-cluster
Notable changes include removing one (but not all) hard-coded ports,
using `common.fail()`, and tidying conditionals and assertions.

PR-URL: #8289
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 10, 2016

test: refactor test-debug-signal-cluster
Notable changes include removing one (but not all) hard-coded ports,
using `common.fail()`, and tidying conditionals and assertions.

PR-URL: #8289
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

rvagg added a commit that referenced this pull request Oct 18, 2016

test: refactor test-debug-signal-cluster
Notable changes include removing one (but not all) hard-coded ports,
using `common.fail()`, and tidying conditionals and assertions.

PR-URL: #8289
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 26, 2016

test: refactor test-debug-signal-cluster
Notable changes include removing one (but not all) hard-coded ports,
using `common.fail()`, and tidying conditionals and assertions.

PR-URL: #8289
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Oct 26, 2016

Closed

V4.6.2 proposal #9298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment