New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify that path.isAbsolute on windows accepts / and \ #8291

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@jasnell
Member

jasnell commented Aug 27, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Clarify that path.isAbsolute() on windows accepts / and \ as path delims

Fixes: #6520

@jasnell jasnell added doc path labels Aug 27, 2016

@lpinca

View changes

Show outdated Hide outdated doc/api/path.md
```
*Note*: On Windows, the `path.isAbsolute()` method will accept both forward
slash (`/`) and backwards slash (`\`) characters as path delimiters.

This comment has been minimized.

@lpinca

lpinca Aug 27, 2016

Member

s/backwards/backward/ ? I'm not a native speaker but "backward slash" has more occurrences on Google.

@lpinca

lpinca Aug 27, 2016

Member

s/backwards/backward/ ? I'm not a native speaker but "backward slash" has more occurrences on Google.

This comment has been minimized.

@addaleax

addaleax Aug 27, 2016

Member

btw, this sounds a bit overly specific, although I might be wrong… is there anything in the Node API where / isn’t accepted on Windows?

@addaleax

addaleax Aug 27, 2016

Member

btw, this sounds a bit overly specific, although I might be wrong… is there anything in the Node API where / isn’t accepted on Windows?

This comment has been minimized.

@jasnell

jasnell Aug 30, 2016

Member

@addaleax ... good point...

@jasnell

jasnell Aug 30, 2016

Member

@addaleax ... good point...

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 30, 2016

Member

@lpinca @addaleax ... updated! PTAL!

Member

jasnell commented Aug 30, 2016

@lpinca @addaleax ... updated! PTAL!

@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca Aug 30, 2016

Member

LGTM.

Member

lpinca commented Aug 30, 2016

LGTM.

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Aug 30, 2016

Member

LGTM

Member

addaleax commented Aug 30, 2016

LGTM

jasnell added a commit that referenced this pull request Aug 30, 2016

doc: clarify that path on windows accepts / and \
Fixes: #6520
PR-URL: #8291
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 30, 2016

Member

Landed in 86067f0. Thanks!

Member

jasnell commented Aug 30, 2016

Landed in 86067f0. Thanks!

@jasnell jasnell closed this Aug 30, 2016

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

doc: clarify that path on windows accepts / and \
Fixes: nodejs#6520
PR-URL: nodejs#8291
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

doc: clarify that path on windows accepts / and \
Fixes: #6520
PR-URL: #8291
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment