New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document what happens when listen is called multiple times #8294

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@jasnell
Member

jasnell commented Aug 27, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Document that listen can be called multiple times.

Fixes: #4646

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Aug 27, 2016

Contributor

LGTM

Contributor

cjihrig commented Aug 27, 2016

LGTM

@mscdex

This comment has been minimized.

Show comment
Hide comment
@mscdex

mscdex Aug 27, 2016

Contributor

Commit message is too long

Contributor

mscdex commented Aug 27, 2016

Commit message is too long

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Aug 27, 2016

Member

Going maybe too off-topic here… is there any chance the length of the title could be renegotiated to something longer or to at least not including the subsystem prefix? 50 characters is a pretty hard limit when you need to include something like child_process: and/or are a non-native speaker with reduced vocabulary…

Member

addaleax commented Aug 27, 2016

Going maybe too off-topic here… is there any chance the length of the title could be renegotiated to something longer or to at least not including the subsystem prefix? 50 characters is a pretty hard limit when you need to include something like child_process: and/or are a non-native speaker with reduced vocabulary…

jasnell added a commit that referenced this pull request Aug 29, 2016

doc: doc that listen can be called multiple times
Fixes: #4646
PR-URL: #8294
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 29, 2016

Member

Landed in 488d37b

Member

jasnell commented Aug 29, 2016

Landed in 488d37b

@jasnell jasnell closed this Aug 29, 2016

@addaleax addaleax referenced this pull request Sep 6, 2016

Closed

net: multiple listen() events fail silently #8419

4 of 4 tasks complete

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

doc: doc that listen can be called multiple times
Fixes: nodejs#4646
PR-URL: nodejs#8294
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

doc: doc that listen can be called multiple times
Fixes: #4646
PR-URL: #8294
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Sep 30, 2016

Member

This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport

Member

MylesBorins commented Sep 30, 2016

This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport

@eduardbcom eduardbcom referenced this pull request May 22, 2017

Closed

net: multiple listen() events fail silently #13149

4 of 4 tasks complete

eduardbcom added a commit to eduardbcom/node that referenced this pull request Jun 22, 2017

net: multiple listen() events fail silently
Problem:
It's possible to run listen()
  on a net.Server that's already listening to a port.
The result is silent failure,
  with the side effect of changing the connectionKey and or pipeName.

Solution:
  emit error if listen method called more than once.
  close() method should be called between listen() method calls.

Refs: nodejs#8294
Fixes: nodejs#6190
Fixes: nodejs#11685

eduardbcom added a commit to eduardbcom/node that referenced this pull request Aug 29, 2017

net: multiple listen() events fail silently
Problem:
It's possible to run listen()
  on a net.Server that's already listening to a port.
The result is silent failure,
  with the side effect of changing the connectionKey and or pipeName.

Solution:
  throw an error if listen method called more than once.
  close() method should be called between listen() method calls.

Refs: nodejs#8294
Fixes: nodejs#6190
Fixes: nodejs#11685

eduardbcom added a commit to eduardbcom/node that referenced this pull request Sep 2, 2017

net: multiple listen() events fail silently
Problem:
It's possible to run listen()
  on a net.Server that's already listening to a port.
The result is silent failure,
  with the side effect of changing the connectionKey and or pipeName.

Solution:
  throw an error if listen method called more than once.
  close() method should be called between listen() method calls.

Refs: nodejs#8294
Fixes: nodejs#6190
Fixes: nodejs#11685

mcollina added a commit that referenced this pull request Sep 4, 2017

net: multiple listen() events fail silently
Problem:
It's possible to run listen()
  on a net.Server that's already listening to a port.
The result is silent failure,
  with the side effect of changing the connectionKey and or pipeName.

Solution:
  throw an error if listen method called more than once.
  close() method should be called between listen() method calls.

Refs: #8294
Fixes: #6190
Fixes: #11685
PR-URL: #13149
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

addaleax added a commit to addaleax/ayo that referenced this pull request Sep 5, 2017

net: multiple listen() events fail silently
Problem:
It's possible to run listen()
  on a net.Server that's already listening to a port.
The result is silent failure,
  with the side effect of changing the connectionKey and or pipeName.

Solution:
  throw an error if listen method called more than once.
  close() method should be called between listen() method calls.

Refs: nodejs/node#8294
Fixes: nodejs/node#6190
Fixes: nodejs/node#11685
PR-URL: nodejs/node#13149
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment